From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-pci: Add support for Intel KBP
Date: Thu, 7 Jul 2016 12:04:21 +0300 [thread overview]
Message-ID: <577E1B15.8080503@intel.com> (raw)
In-Reply-To: <CAPDyKFpSMJ-StCwNdk-w8g44tBfZKF8y6Au2mxEiAa7uSjSG_A@mail.gmail.com>
On 22/06/16 18:24, Ulf Hansson wrote:
> On 22 June 2016 at 13:19, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> Add PCI ID for Intel KBP SD host controller.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks, applied for next!
It turns out this ID is wrong! Can you please drop this patch from next?
>
> Kind regards
> Uffe
>
>> ---
>> drivers/mmc/host/sdhci-pci-core.c | 8 ++++++++
>> drivers/mmc/host/sdhci-pci.h | 1 +
>> 2 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index a4dbf7421edc..5b03a7ecc6c9 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -1215,6 +1215,14 @@ static const struct pci_device_id pci_ids[] = {
>> },
>>
>> {
>> + .vendor = PCI_VENDOR_ID_INTEL,
>> + .device = PCI_DEVICE_ID_INTEL_KBP_SD,
>> + .subvendor = PCI_ANY_ID,
>> + .subdevice = PCI_ANY_ID,
>> + .driver_data = (kernel_ulong_t)&sdhci_intel_byt_sd,
>> + },
>> +
>> + {
>> .vendor = PCI_VENDOR_ID_O2,
>> .device = PCI_DEVICE_ID_O2_8120,
>> .subvendor = PCI_ANY_ID,
>> diff --git a/drivers/mmc/host/sdhci-pci.h b/drivers/mmc/host/sdhci-pci.h
>> index 89e7151684a1..968b81ed8e4d 100644
>> --- a/drivers/mmc/host/sdhci-pci.h
>> +++ b/drivers/mmc/host/sdhci-pci.h
>> @@ -34,6 +34,7 @@
>> #define PCI_DEVICE_ID_INTEL_APL_SD 0x5aca
>> #define PCI_DEVICE_ID_INTEL_APL_EMMC 0x5acc
>> #define PCI_DEVICE_ID_INTEL_APL_SDIO 0x5ad0
>> +#define PCI_DEVICE_ID_INTEL_KBP_SD 0xa2f5
>>
>> /*
>> * PCI registers
>> --
>> 1.9.1
>>
>
next prev parent reply other threads:[~2016-07-07 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 11:19 [PATCH] mmc: sdhci-pci: Add support for Intel KBP Adrian Hunter
2016-06-22 15:24 ` Ulf Hansson
2016-07-07 9:04 ` Adrian Hunter [this message]
2016-07-12 10:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E1B15.8080503@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox