From: Paul Parsons <lost.distance@yahoo.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <damm@opensource.se>,
Simon Horman <horms@verge.net.au>,
Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling
Date: Fri, 22 Apr 2011 12:13:02 +0100 (BST) [thread overview]
Message-ID: <57837.39952.qm@web29020.mail.ird.yahoo.com> (raw)
In-Reply-To: <504862.26396.qm@web29015.mail.ird.yahoo.com>
--- On Fri, 22/4/11, Paul Parsons <lost.distance@yahoo.com> wrote:
> As far as I can see the expression
>
> (ios->clock == 0 && ios->power_mode ==
> MMC_POWER_ON)
>
> will only be true if host->f_init == 0 at the time
> MMC_POWER_ON is invoked in mmc_power_up(). Presumably that
> case is intentional.
Sorry, ignore this; I missed the case where mmc_gate_clock() sets ios->clock = 0 before calling mmc_set_ios().
prev parent reply other threads:[~2011-04-22 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 7:09 [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling Guennadi Liakhovetski
2011-04-21 15:35 ` Chris Ball
2011-04-22 4:24 ` Paul Parsons
2011-04-22 11:13 ` Paul Parsons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57837.39952.qm@web29020.mail.ird.yahoo.com \
--to=lost.distance@yahoo.com \
--cc=cjb@laptop.org \
--cc=damm@opensource.se \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox