From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alim Akhtar Subject: Re: [1/2] mmc: dw_mmc: set to MMC_CAP_ERASE by default Date: Fri, 15 Jul 2016 10:08:43 +0530 Message-ID: <578868D3.4080905@samsung.com> References: <1468547691-4525-1-git-send-email-jh80.chung@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:43108 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbcGOEjK (ORCPT ); Fri, 15 Jul 2016 00:39:10 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAC01B0MA989I40@mailout4.samsung.com> for linux-mmc@vger.kernel.org; Fri, 15 Jul 2016 13:39:08 +0900 (KST) In-reply-to: <1468547691-4525-1-git-send-email-jh80.chung@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jaehoon Chung , linux-mmc@vger.kernel.org Cc: ulf.hansson@linaro.org, shawn.lin@rock-chips.com Hi Jaehoon On 07/15/2016 07:24 AM, Jaehoon Chung wrote: > This flag needs to use the trim/discard/erase commands. > dwmmc controller enables this flag by default. > > Signed-off-by: Jaehoon Chung > Reviewed-by: Shawn Lin > --- > drivers/mmc/host/dw_mmc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 9fab5ed..d16de19 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2604,6 +2604,12 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > if (host->pdata->caps) > mmc->caps = host->pdata->caps; > > + /* > + * Support MMC_CAP_ERASE by default. > + * It needs to use trim/discard/erase commands. > + */ > + mmc->caps |= MMC_CAP_ERASE; > + Just a thought, probably this should be move to mmc_of_parse() and let the board/platform configure this via device-tree. > if (host->pdata->pm_caps) > mmc->pm_caps = host->pdata->pm_caps; > >