From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset Date: Tue, 26 Jul 2016 09:49:01 +0900 Message-ID: <5796B37D.70001@samsung.com> References: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com> <5788637F.2070908@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:53462 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbcGZAtG (ORCPT ); Mon, 25 Jul 2016 20:49:06 -0400 In-reply-to: <5788637F.2070908@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Alim Akhtar , Krzysztof Kozlowski , Ulf Hansson , Kukjin Kim , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz On 07/15/2016 01:15 PM, Alim Akhtar wrote: > Hi Krzysztof, > > On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote: >> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to >> configure HS400 timing, this might or might not work. Warn in such >> cases because this is DTB misconfiguration. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > Reviewed-by: Alim Akhtar Applied on my repository. Thanks! Before applied, I modified the prefix of subject from "dwmmc" to "dw_mmc" Best Regards, Jaehoon Chung > >> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c >> index da0ef1765735..7ab3d749b5ae 100644 >> --- a/drivers/mmc/host/dw_mmc-exynos.c >> +++ b/drivers/mmc/host/dw_mmc-exynos.c >> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) >> * Not supported to configure register >> * related to HS400 >> */ >> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) >> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) { >> + if (timing == MMC_TIMING_MMC_HS400) >> + dev_warn(host->dev, >> + "cannot configure HS400, unsupported chipset\n"); >> return; >> + } >> > It is good to have extra bit of debug information handy. > >> dqs = priv->saved_dqs_en; >> strobe = priv->saved_strobe_ctrl; >> > >