* [PATCH] mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
@ 2016-07-14 13:22 Krzysztof Kozlowski
2016-07-15 4:15 ` Alim Akhtar
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-07-14 13:22 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson, Kukjin Kim, Krzysztof Kozlowski,
linux-mmc, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
configure HS400 timing, this might or might not work. Warn in such
cases because this is DTB misconfiguration.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index da0ef1765735..7ab3d749b5ae 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
* Not supported to configure register
* related to HS400
*/
- if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
+ if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
+ if (timing == MMC_TIMING_MMC_HS400)
+ dev_warn(host->dev,
+ "cannot configure HS400, unsupported chipset\n");
return;
+ }
dqs = priv->saved_dqs_en;
strobe = priv->saved_strobe_ctrl;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
2016-07-14 13:22 [PATCH] mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset Krzysztof Kozlowski
@ 2016-07-15 4:15 ` Alim Akhtar
2016-07-26 0:49 ` Jaehoon Chung
0 siblings, 1 reply; 3+ messages in thread
From: Alim Akhtar @ 2016-07-15 4:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jaehoon Chung, Ulf Hansson, Kukjin Kim,
linux-mmc, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
Hi Krzysztof,
On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote:
> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
> configure HS400 timing, this might or might not work. Warn in such
> cases because this is DTB misconfiguration.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index da0ef1765735..7ab3d749b5ae 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
> * Not supported to configure register
> * related to HS400
> */
> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
> + if (timing == MMC_TIMING_MMC_HS400)
> + dev_warn(host->dev,
> + "cannot configure HS400, unsupported chipset\n");
> return;
> + }
>
It is good to have extra bit of debug information handy.
> dqs = priv->saved_dqs_en;
> strobe = priv->saved_strobe_ctrl;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset
2016-07-15 4:15 ` Alim Akhtar
@ 2016-07-26 0:49 ` Jaehoon Chung
0 siblings, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2016-07-26 0:49 UTC (permalink / raw)
To: Alim Akhtar, Krzysztof Kozlowski, Ulf Hansson, Kukjin Kim,
linux-mmc, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
On 07/15/2016 01:15 PM, Alim Akhtar wrote:
> Hi Krzysztof,
>
> On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote:
>> Chipsets before Exynos5420 did not support HS400 so if MMC core tries to
>> configure HS400 timing, this might or might not work. Warn in such
>> cases because this is DTB misconfiguration.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Applied on my repository. Thanks!
Before applied, I modified the prefix of subject from "dwmmc" to "dw_mmc"
Best Regards,
Jaehoon Chung
>
>> drivers/mmc/host/dw_mmc-exynos.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
>> index da0ef1765735..7ab3d749b5ae 100644
>> --- a/drivers/mmc/host/dw_mmc-exynos.c
>> +++ b/drivers/mmc/host/dw_mmc-exynos.c
>> @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing)
>> * Not supported to configure register
>> * related to HS400
>> */
>> - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420)
>> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) {
>> + if (timing == MMC_TIMING_MMC_HS400)
>> + dev_warn(host->dev,
>> + "cannot configure HS400, unsupported chipset\n");
>> return;
>> + }
>>
> It is good to have extra bit of debug information handy.
>
>> dqs = priv->saved_dqs_en;
>> strobe = priv->saved_strobe_ctrl;
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-26 0:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-14 13:22 [PATCH] mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset Krzysztof Kozlowski
2016-07-15 4:15 ` Alim Akhtar
2016-07-26 0:49 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).