From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
ulf.hansson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org,
huziji@marvell.com, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mmc: xenon: Convert to JSON schema
Date: Thu, 31 Mar 2022 11:38:16 +0200 [thread overview]
Message-ID: <5dea78a0-83ed-c016-35c6-637c8a445005@linaro.org> (raw)
In-Reply-To: <ad213f38-f0a2-6420-cfa0-a9ba7cb362d5@linaro.org>
On 30/03/2022 09:20, Krzysztof Kozlowski wrote:
> On 30/03/2022 00:05, Chris Packham wrote:
>> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the
>> in-tree dts files don't validate because they use sdhci@ instead of mmc@
>> as required by the generic mmc-controller schema.
>>
>> The compatible "marvell,sdhci-xenon" was not documented in the old
>> binding but it accompanies the of "marvell,armada-3700-sdhci" in the
>> armada-37xx SoC dtsi so this combination is added to the new binding
>> document.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>
>> Notes:
>> Changes in v5:
>> - Fix silly error in examples
>> Changes in v4:
>> - Add review from Krzysztof
>> - Squash in addition of marvell,sdhci-xenon with an explanation in the
>> commit message
>> Changes in v3:
>> - Don't accept ap807 without ap806
>> - Add ref: string for pad-type
>> Changes in v2:
>> - Update MAINTAINERS entry
>> - Incorporate feedback from Krzysztof
>>
>> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 -----------
>> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++
>> MAINTAINERS | 2 +-
>> 3 files changed, 276 insertions(+), 174 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
>> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
>>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Oh, this should be only one review tag. Preferably @linaro.org. Sorry
for the noise.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-31 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 22:05 [PATCH v5 0/2] mmc: xenon: Convert to JSON schema Chris Packham
2022-03-29 22:05 ` [PATCH v5 1/2] arm64: dts: marvell: Update sdhci node names to match schema Chris Packham
2022-05-09 9:26 ` Gregory CLEMENT
2022-03-29 22:05 ` [PATCH v5 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Chris Packham
2022-03-30 7:20 ` Krzysztof Kozlowski
2022-03-31 9:38 ` Krzysztof Kozlowski [this message]
2022-04-06 14:55 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dea78a0-83ed-c016-35c6-637c8a445005@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=huziji@marvell.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox