From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH RFC 0/5] mmc: sdhci: Tidy tuning
Date: Fri, 2 Dec 2016 10:28:26 +0200 [thread overview]
Message-ID: <5f30261c-3e5e-bae1-b706-434cfa024534@intel.com> (raw)
In-Reply-To: <CAPDyKFqbpGQuzirU98MTX4TXjn6inDY8K8NozrSwBZVJGMDyLg@mail.gmail.com>
On 01/12/16 16:57, Ulf Hansson wrote:
> On 1 December 2016 at 15:04, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> Hi
>>
>> Here are some tidy-ups wrt SDHCI tuning. Un-tested so far.
>
> Nice. Thanks!
>
>>
>> Any other suggestions? Otherwise I will test and submit the whole series.
>
> As an additional step, could you try to make use of mmc_send_tuning(),
> instead of sending the command internally from sdhci_send_tuning()?
mmc_send_tuning() is not a good fit. SDHCI tuning command does not have a
data payload (or rather the hardware does it automatically) so unless
mmc_send_tuning() is changed it will return -EIO. If that is changed then,
SDHCI request function needs to be changed to special-case the tuning
command because the interrupt setup is different. Then the problem is that
there is no timeout interrupt so another timer is needed, so a special case
would have to be created for that too.
The current code is much simpler.
next prev parent reply other threads:[~2016-12-02 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 14:04 [PATCH RFC 0/5] mmc: sdhci: Tidy tuning Adrian Hunter
2016-12-01 14:04 ` [PATCH RFC 1/5] mmc: mmc: Introduce mmc_abort_tuning() Adrian Hunter
2016-12-01 14:04 ` [PATCH RFC 2/5] mmc: sdhci: Use mmc_abort_tuning() Adrian Hunter
2016-12-01 14:04 ` [PATCH RFC 3/5] mmc: sdhci: Factor out tuning helper functions Adrian Hunter
2016-12-01 14:04 ` [PATCH RFC 4/5] mmc: sdhci: Simplify tuning block size logic Adrian Hunter
2016-12-01 14:04 ` [PATCH RFC 5/5] mmc: sdhci: Tidy tuning loop Adrian Hunter
2016-12-01 14:57 ` [PATCH RFC 0/5] mmc: sdhci: Tidy tuning Ulf Hansson
2016-12-02 8:28 ` Adrian Hunter [this message]
2016-12-02 13:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f30261c-3e5e-bae1-b706-434cfa024534@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox