Re: [PATCH 06/12] mmc: meson-mx-sdio: Fix misuse of GENMASK macro

Neil Armstrong
2019-07-22T07:23:16Z

On 10/07/2019 07:04, Joe Perches wrote:
> Arguments are supposed to be ordered high then low.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mmc/host/meson-mx-sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
> index 2d736e416775..ba9a63db73da 100644
> --- a/drivers/mmc/host/meson-mx-sdio.c
> +++ b/drivers/mmc/host/meson-mx-sdio.c
> @@ -73,7 +73,7 @@
> #define MESON_MX_SDIO_IRQC_IF_CONFIG_MASK GENMASK(7, 6)
> #define MESON_MX_SDIO_IRQC_FORCE_DATA_CLK BIT(8)
> #define MESON_MX_SDIO_IRQC_FORCE_DATA_CMD BIT(9)
> - #define MESON_MX_SDIO_IRQC_FORCE_DATA_DAT_MASK GENMASK(10, 13)
> + #define MESON_MX_SDIO_IRQC_FORCE_DATA_DAT_MASK GENMASK(13, 10)
> #define MESON_MX_SDIO_IRQC_SOFT_RESET BIT(15)
> #define MESON_MX_SDIO_IRQC_FORCE_HALT BIT(30)
> #define MESON_MX_SDIO_IRQC_HALT_HOLE BIT(31)
>

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>