Re: [PATCH] mmc: moxart: fix probe logic

Arnd Bergmann
2015-01-29T22:04:54Z

On Thursday 29 January 2015 17:01:04 Russell King - ARM Linux wrote:
> On Thu, Jan 29, 2015 at 05:15:31PM +0100, Arnd Bergmann wrote:
> > @@ -586,10 +586,10 @@ static int moxart_probe(struct platform_device *pdev)
> > goto out;
> > }
> >
> > - clk = of_clk_get(node, 0);
> > - if (IS_ERR(clk)) {
> > + host->clk = of_clk_get(node, 0);
> > + if (IS_ERR(host->clk)) {
> > dev_err(dev, "of_clk_get failed\n");
> > - ret = PTR_ERR(clk);
> > + ret = PTR_ERR(host->clk);
> > goto out;
> > }
> >
> ...
> > @@ -677,6 +679,8 @@ static int moxart_probe(struct platform_device *pdev)
> > return 0;
> >
> > out:
> > + if (host->clk)
> > + clk_put(host->clk);
>
> Are you sure?
>

Oops, sorry about that.

Thanks for the review! Fixed patch follows.

Arnd