Re: [PATCH v3] mmc: moxart: fix probe logic

Arnd Bergmann
2015-02-03T09:07:33Z

On Tuesday 03 February 2015 09:02:22 Ulf Hansson wrote:
> > @@ -586,10 +588,11 @@ static int moxart_probe(struct platform_device *pdev)
> > goto out;
> > }
> >
> > - clk = of_clk_get(node, 0);
>
> This code would be simpler using devm_clk_get(), since then error
> wouldn't be needed.
>
> Any reason to why you don't want to use that?

You are absolutely right, and that would have avoided both of the bugs
I introduced.

Arnd