From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] mmc: sdhci-xenon: Mark expected switch fall-through Date: Wed, 13 Feb 2019 12:13:26 -0600 Message-ID: <657aa413-f36e-8b5b-edd2-756edd24b74c@embeddedor.com> References: <20190212152558.GA21933@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: Adrian Hunter , Hu Ziji , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Kees Cook List-Id: linux-mmc@vger.kernel.org On 2/13/19 2:35 AM, Ulf Hansson wrote: > On Tue, 12 Feb 2019 at 16:26, Gustavo A. R. Silva > wrote: >> >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/mmc/host/sdhci-xenon-phy.c: In function ‘xenon_emmc_phy_slow_mode’: >> drivers/mmc/host/sdhci-xenon-phy.c:527:47: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if ((priv->init_card_type == MMC_TYPE_SDIO) || >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ >> params->slow_mode) { >> ~~~~~~~~~~~~~~~~~ >> drivers/mmc/host/sdhci-xenon-phy.c:534:2: note: here >> default: >> ^~~~~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice that, in this particular case, the code comment is modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied for next - and by cleaning up the somewhat noisy change log, thanks! > Great. Thanks, Uffe. -- Gustavo