From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SY8UfsrI" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66BE1BE; Mon, 11 Dec 2023 03:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702294739; x=1733830739; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=eyVCBatfunUiT8to3dekFlZQJ+ZCTmarYw1xVr8nuiw=; b=SY8UfsrIH+MjetSm/VA6l6gF/K0AKsgturXkUlPgFclwb5i5fFStKvl9 YVzJNJWqX7uDeXOPZXo6Zl1RbM8EDxIkWAmS2FVVpaP6mO1yy0jN1M04S DSHS6PUJFmhrBpFn05VL6I+DtSI/xNHuQXnG59nbkoAZ5wos2lOV59iqT qvLlVr5t2mzt31I24hIg46rGX6El55UpioCOONpCClLA8OsYXR9UZEjvM g7kSWLBMBEIJU5EU13J+6CPGtm2JV5VZOtfWYOJHca8pjmqEK4AM4MCjO /KJ5MdtrUpemvqqhzJOFQMRwABtCKrujqeEBshKpC7eO44JcF07kDHmkM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="1473853" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="1473853" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 03:38:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="17579443" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.46.23]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 03:38:52 -0800 Message-ID: <66aa74f5-0613-49eb-80d3-ce4381f717ae@intel.com> Date: Mon, 11 Dec 2023 13:38:49 +0200 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-dwcmshc: Enable timeout quirk for BlueField-3 SoC Content-Language: en-US To: Liming Sun , Christian Loehle , Ulf Hansson , David Thompson Cc: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <6082b74cbc681e8c24354828941361f4f4294242.1700315051.git.limings@nvidia.com> <3912dd1e-b15b-49a9-9c91-88e00e986efd@arm.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/11/23 15:19, Liming Sun wrote: > > >> -----Original Message----- >> From: Christian Loehle >> Sent: Monday, November 27, 2023 8:36 AM >> To: Liming Sun ; Adrian Hunter >> ; Ulf Hansson ; David >> Thompson >> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v1 1/1] mmc: sdhci-of-dwcmshc: Enable timeout quirk for >> BlueField-3 SoC >> >> On 18/11/2023 13:46, Liming Sun wrote: >>> This commit enables SDHCI_QUIRK_BROKEN_TIMEOUT_VAL to solve the >>> intermittent eMMC timeout issue reported on some cards under eMMC >>> stress test. >>> >>> Reported error message: >>> dwcmshc MLNXBF30:00: __mmc_blk_ioctl_cmd: data error -110 >>> >>> Signed-off-by: Liming Sun >>> --- >>> drivers/mmc/host/sdhci-of-dwcmshc.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c >> b/drivers/mmc/host/sdhci-of-dwcmshc.c >>> index 3a3bae6948a8..3c8fe8aec558 100644 >>> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c >>> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c >>> @@ -365,7 +365,8 @@ static const struct sdhci_pltfm_data >> sdhci_dwcmshc_pdata = { >>> #ifdef CONFIG_ACPI >>> static const struct sdhci_pltfm_data sdhci_dwcmshc_bf3_pdata = { >>> .ops = &sdhci_dwcmshc_ops, >>> - .quirks = SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN, >>> + .quirks = SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN | >>> + SDHCI_QUIRK_BROKEN_TIMEOUT_VAL, >>> .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | >>> SDHCI_QUIRK2_ACMD23_BROKEN, >>> }; >> >> __mmc_blk_ioctl_cmd: data error ? >> What stresstest are you running that issues ioctl commands? >> On which commands does the timeout occur? >> Anyway you should be able to increase the timeout in ioctl structure >> directly, i.e. in userspace, or does that not work? > > It's running stress test with tool like "fio --name=randrw_stress_round_1 --ioengine=libaio --direct=1 --time_based=1 --end_fsync=1 --ramp_time=5 --norandommap=1 --randrepeat=0 --group_reporting=1 --numjobs=4 --iodepth=128 --rw=randrw --overwrite=1 --runtime=36000 --bssplit=4K/44:8K/1:12K/1:16K/1:24K/1:28K/1:32K/1:40K/32:64K/5:68K/7:72K/3:76K/3 --filename=/dev/mmcblk0" > The tool(application) is owned by user or with some standard tool. fio does not send mmc ioctls, so I am also a bit confused about how you get "__mmc_blk_ioctl_cmd: data error -110" ?