Re: [PATCH v2 6/6] mtd: parser: add support for Airoha parser

Christian Marangi
2024-08-06T11:32:59Z

On Tue, Aug 06, 2024 at 05:23:43PM +0800, Philip Li wrote:
> On Mon, Aug 05, 2024 at 04:54:45AM +0200, Christian Marangi wrote:
> > On Mon, Aug 05, 2024 at 06:52:04AM +0800, kernel test robot wrote:
> > > Hi Christian,
> > >
> > > kernel test robot noticed the following build errors:
> > >
> > > [auto build test ERROR on robh/for-next]
> > > [also build test ERROR on linus/master v6.11-rc1 next-20240802]
> > > [cannot apply to mtd/mtd/next mtd/mtd/fixes]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > >
> > > url: https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-nvme-Document-nvme-card-compatible/20240805-014740
> > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> > > patch link: https://lore.kernel.org/r/20240804174414.18171-7-ansuelsmth%40gmail.com
> > > patch subject: [PATCH v2 6/6] mtd: parser: add support for Airoha parser
> > > config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/config)
> > > compiler: xtensa-linux-gcc (GCC) 14.1.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202408050612.Ya1m6REu-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > drivers/mtd/parsers/ofpart_airoha.c: In function 'airoha_partitions_post_parse':
> > > drivers/mtd/parsers/ofpart_airoha.c:33:16: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
> > > 33 | prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> > > | ^~~~~~~
> > > >> drivers/mtd/parsers/ofpart_airoha.c:33:14: error: assignment to 'struct property *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> > > 33 | prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> > > | ^
> > >
> > >
> > > vim +33 drivers/mtd/parsers/ofpart_airoha.c
> > >
> > > 10
> > > 11 int airoha_partitions_post_parse(struct mtd_info *mtd,
> > > 12 struct mtd_partition *parts,
> > > 13 int nr_parts)
> > > 14 {
> > > 15 struct mtd_partition *part;
> > > 16 int len, a_cells, s_cells;
> > > 17 struct device_node *pp;
> > > 18 struct property *prop;
> > > 19 const __be32 *reg;
> > > 20 __be32 *new_reg;
> > > 21
> > > 22 part = &parts[nr_parts - 1];
> > > 23 pp = part->of_node;
> > > 24
> > > 25 /* Skip if ART partition have a valid offset instead of a dynamic one */
> > > 26 if (!of_device_is_compatible(pp, "airoha,dynamic-art"))
> > > 27 return 0;
> > > 28
> > > 29 /* ART partition is set at the end of flash - size */
> > > 30 part->offset = mtd->size - part->size;
> > > 31
> > > 32 /* Update the offset with the new calculate value in DT */
> > > > 33 prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> > >
> > > --
> > > 0-DAY CI Kernel Test Service
> > > https://github.com/intel/lkp-tests/wiki
> >
> > Mhhh somehow I can't repro this with instructions?
>
> Hi Ansuel, would you mind sharing the steps of reproduce? I can reproduce this with steps
> described in the repro link [1]
>
> [1] https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/reproduce
>

Hi, thanks for confirming that. Manage to repro, just had dirty
build-dir and config wasn't correctly applying.

--
Ansuel