From: Adrian Hunter <adrian.hunter@intel.com>
To: Dong Aisheng <dongas86@gmail.com>, Haibo Chen <haibo.chen@nxp.com>
Cc: ulf.hansson@linaro.org, aisheng.dong@nxp.com, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: correct the max timeout count
Date: Thu, 18 Aug 2016 15:55:17 +0300 [thread overview]
Message-ID: <680be0ba-3096-fbde-d337-0caeaac25ff9@intel.com> (raw)
In-Reply-To: <20160816074457.GB9211@shlinux2>
On 16/08/16 10:44, Dong Aisheng wrote:
> On Mon, Aug 15, 2016 at 04:31:33PM +0800, Haibo Chen wrote:
>> i.MX USDHC Reference Manual has a mistake, for the register SYS_CTRL,
>> the DTOCV(bit 19~16) means the data timeout counter value. When DTOCV
>> is set to 0xF, it means SDCLK << 29, not SDCLK << 28.
>>
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>> ---
>> drivers/mmc/host/sdhci-esdhc-imx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
>> index 437c448..ea7d086 100644
>> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
>> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
>> @@ -929,7 +929,7 @@ static unsigned int esdhc_get_max_timeout_count(struct sdhci_host *host)
>> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host);
>>
>
> Better add a comment here like:
> /* Doc Errata: the uSDHC actual maximum timeout count is 1 << 29 */
>
>> - return esdhc_is_usdhc(imx_data) ? 1 << 28 : 1 << 27;
>> + return esdhc_is_usdhc(imx_data) ? 1 << 29 : 1 << 27;
>
> Otherwise:
> Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Please take account of Dong's comment, otherwise:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Regards
> Dong Aisheng
>
>> }
>>
>> static void esdhc_set_timeout(struct sdhci_host *host, struct mmc_command *cmd)
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-08-18 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 8:31 [PATCH] mmc: sdhci-esdhc-imx: correct the max timeout count Haibo Chen
2016-08-16 7:44 ` Dong Aisheng
2016-08-18 12:55 ` Adrian Hunter [this message]
2016-08-22 13:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=680be0ba-3096-fbde-d337-0caeaac25ff9@intel.com \
--to=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox