From: merez@codeaurora.org
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
'Chris Ball' <cjb@laptop.org>, 'Maya Erez' <merez@codeaurora.org>,
'Subhash Jadavani' <subhashj@codeaurora.org>,
"'S, Venkatraman'" <svenkatr@ti.com>
Subject: Re: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5
Date: Mon, 11 Jun 2012 13:26:53 -0700 (PDT) [thread overview]
Message-ID: <68ac9afd251593ab3df348a469a10adb.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <000601cd47ab$8ad77c50$a08674f0$%jun@samsung.com>
> + if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> + ((card->ext_csd.max_packed_writes > 0) ||
> + (card->ext_csd.max_packed_reads > 0))) {
> + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> + EXT_CSD_EXP_EVENTS_CTRL,
> + EXT_CSD_PACKED_EVENT_EN,
> + card->ext_csd.generic_cmd6_time);
> + if (err && err != -EBADMSG)
> + goto free_card;
Subhash suggestion to change to the following is missing:
if ( (host->caps2 & MMC_CAP2_PACKED_WR &&
card->ext_csd.max_packed_writes > 0) ||
(host->caps2 & MMC_CAP2_PACKED_RD &&
card->ext_csd.max_packed_reads > 0)
Thanks,
Maya Erez
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2012-06-11 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 8:23 [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5 Seungwon Jeon
2012-06-11 20:26 ` merez [this message]
2012-06-12 3:12 ` Seungwon Jeon
2012-06-12 4:21 ` S, Venkatraman
2012-06-12 13:05 ` Seungwon Jeon
2012-06-12 19:15 ` merez
2012-06-13 19:49 ` S, Venkatraman
2012-06-13 21:43 ` merez
2012-06-14 3:10 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ac9afd251593ab3df348a469a10adb.squirrel@www.codeaurora.org \
--to=merez@codeaurora.org \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=subhashj@codeaurora.org \
--cc=svenkatr@ti.com \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).