From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: sbranden@broadcom.com, Weijun Yang <Weijun.Yang@csr.com>,
Andrew Bresticker <abrestic@chromium.org>,
Jean Delvare <jdelvare@suse.de>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-mmc@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
addy ke <addy.ke@rock-chips.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Kevin Hao <haokexin@gmail.com>,
Vincent Yang <vincent.yang.fujitsu@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI
Date: Thu, 6 Aug 2015 07:39:26 +0200 [thread overview]
Message-ID: <6906e34b62f162018984a5fbd12b3ef6cd5e3a29.1438839562.git.michal.simek@xilinx.com> (raw)
Add GPIOLIB dependency for MMC_SDHCI.
Problem was observed after adding the patch
"mmc: sdhci-of-arasan: Call OF parsing for MMC"
(sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls
mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which
calls devm_gpiod_get_index() which returns -ENOSYS.
Error log:
sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258)
sdhci-arasan: probe of ff160000.sdhci failed with error -38
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
After RFC here https://lkml.org/lkml/2015/7/24/371
adding dependency on MMC_SDHCI.
---
drivers/mmc/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index fd9a58e216a5..5519803c124b 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -38,6 +38,7 @@ config MMC_PXA
config MMC_SDHCI
tristate "Secure Digital Host Controller Interface support"
depends on HAS_DMA
+ depends on GPIOLIB
help
This selects the generic Secure Digital Host Controller Interface.
It is used by manufacturers such as Texas Instruments(R), Ricoh(R)
--
2.3.5
next reply other threads:[~2015-08-06 5:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:39 Michal Simek [this message]
2015-08-25 12:04 ` [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI Ulf Hansson
2015-08-27 11:32 ` Ulf Hansson
2015-08-27 11:43 ` Michal Simek
2015-08-27 12:30 ` Ulf Hansson
2015-08-27 13:43 ` Michal Simek
2015-08-27 14:12 ` Ulf Hansson
2015-08-27 14:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6906e34b62f162018984a5fbd12b3ef6cd5e3a29.1438839562.git.michal.simek@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=Weijun.Yang@csr.com \
--cc=abrestic@chromium.org \
--cc=addy.ke@rock-chips.com \
--cc=alim.akhtar@samsung.com \
--cc=chaotian.jing@mediatek.com \
--cc=haokexin@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=sboyd@codeaurora.org \
--cc=sbranden@broadcom.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.yang.fujitsu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).