From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Date: Tue, 11 Sep 2012 07:43:17 -0500 Message-ID: <6D8C87BA-CA06-4215-94F5-63EBF5162B0A@kernel.crashing.org> References: <1347347565-17474-1-git-send-email-Chang-Ming.Huang@freescale.com> <1347347565-17474-2-git-send-email-Chang-Ming.Huang@freescale.com> <20120911075429.GA27028@lizard> <20120911080457.GA28235@lizard> <110EED8CC96DFC488B7E717A2027A27C176170@039-SN1MPN1-002.039d.mgd.msft.net> Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: Received: from gate.crashing.org ([63.228.1.57]:58081 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898Ab2IKMn0 convert rfc822-to-8bit (ORCPT ); Tue, 11 Sep 2012 08:43:26 -0400 In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C176170@039-SN1MPN1-002.039d.mgd.msft.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Huang Changming-R66093 Cc: Anton Vorontsov , "linux-mmc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" On Sep 11, 2012, at 4:36 AM, Huang Changming-R66093 wrote: > Thanks, Anton. > If it is necessary, I will resend this patch to linuxppc-dev@lists.ozlabs.org. > > Best Regards > Jerry Huang I'm still not convinced this is the way to handle this issue. It seems as if the linux driver code makes some assumptions about CMD23 support that it shouldn't. - k > > >> -----Original Message----- >> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com] >> Sent: Tuesday, September 11, 2012 4:05 PM >> To: Huang Changming-R66093 >> Cc: linux-mmc@vger.kernel.org; Kumar Gala; linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 >> >> On Tue, Sep 11, 2012 at 12:54:29AM -0700, Anton Vorontsov wrote: >>> On Tue, Sep 11, 2012 at 03:12:44PM +0800, Chang- >> Ming.Huang@freescale.com wrote: >>>> From: Jerry Huang >>>> >>>> Below SOCs don't support the cmd23 command for MMC card, therefore, >>>> disable it in device tree: >>>> P1020, P1021, P1022, P1024, P1025 and P4080 >>>> >>>> Signed-off-by: Jerry Huang >>> >>> Acked-by: Anton Vorontsov >> >> Btw, although the patch is trivial, I guess you still want to let know >> PowerPC folks about it. Adding Cc and copying the patch: >> >> - - - - >> From: Jerry Huang >> >> Below SOCs don't support the cmd23 command for MMC card, therefore, >> disable it in device tree: >> P1020, P1021, P1022, P1024, P1025 and P4080 >> >> Signed-off-by: Jerry Huang >> CC: Anton Vorontsov >> --- >> arch/powerpc/boot/dts/fsl/p1020si-post.dtsi | 1 + >> arch/powerpc/boot/dts/fsl/p1021si-post.dtsi | 1 + >> arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 1 + >> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 1 + >> 4 files changed, 4 insertions(+) >> >> diff --git a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi >> b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi >> index 68cc5e7..793a30b 100644 >> --- a/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi >> +++ b/arch/powerpc/boot/dts/fsl/p1020si-post.dtsi >> @@ -154,6 +154,7 @@ >> sdhc@2e000 { >> compatible = "fsl,p1020-esdhc", "fsl,esdhc"; >> sdhci,auto-cmd12; >> + sdhci,no-cmd23; >> }; >> /include/ "pq3-sec3.3-0.dtsi" >> >> diff --git a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi >> b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi >> index adb82fd..2b7fd2a 100644 >> --- a/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi >> +++ b/arch/powerpc/boot/dts/fsl/p1021si-post.dtsi >> @@ -149,6 +149,7 @@ >> /include/ "pq3-esdhc-0.dtsi" >> sdhc@2e000 { >> sdhci,auto-cmd12; >> + sdhci,no-cmd23; >> }; >> >> /include/ "pq3-sec3.3-0.dtsi" >> diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi >> b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi >> index 06216b8..2334a52 100644 >> --- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi >> +++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi >> @@ -215,6 +215,7 @@ >> sdhc@2e000 { >> compatible = "fsl,p1022-esdhc", "fsl,esdhc"; >> sdhci,auto-cmd12; >> + sdhci,no-cmd23; >> }; >> >> /include/ "pq3-sec3.3-0.dtsi" >> diff --git a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi >> b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi >> index 8d35d2c..5b39952 100644 >> --- a/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi >> +++ b/arch/powerpc/boot/dts/fsl/p4080si-post.dtsi >> @@ -337,6 +337,7 @@ >> sdhc@114000 { >> voltage-ranges = <3300 3300>; >> sdhci,auto-cmd12; >> + sdhci,no-cmd23; >> }; >> >> /include/ "qoriq-i2c-0.dtsi" >> -- >> 1.7.9.5 >