From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stanislav Jakubek <stano.jakubek@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: sdhci-sprd: convert to YAML
Date: Mon, 8 Jul 2024 09:42:01 +0200 [thread overview]
Message-ID: <6a071bbe-a23b-4a2e-a772-a70b46eac970@kernel.org> (raw)
In-Reply-To: <ZolHqsBnQxSo6SbT@standask-GA-A55M-S2HP>
On 06/07/2024 15:33, Stanislav Jakubek wrote:
> Covert the Spreadtrum SDHCI controller bindings to DT schema.
> Rename the file to match compatible.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
> Node name adjustments in DTS are being handled as part of:
> https://lore.kernel.org/lkml/cover.1720112081.git.stano.jakubek@gmail.com/
Thanks
> + clocks:
> + minItems: 2
> + items:
> + - description: SDIO source clock
> + - description: gate clock for enabling/disabling the device
> + - description: gate clock controlling the device for some special platforms (optional)
> +
> + clock-names:
> + minItems: 2
> + items:
> + - const: sdio
> + - const: enable
> + - const: 2x_enable
> +
> + assigned-clocks:
> + maxItems: 1
> +
> + assigned-clock-parents:
> + maxItems: 1
Drop both assigned-... properties, should not be needed.
> +
> + pinctrl-0:
> + description: default/high speed pin control
> + maxItems: 1
> +
Rest looks good, so with above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-08 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 13:33 [PATCH] dt-bindings: mmc: sdhci-sprd: convert to YAML Stanislav Jakubek
2024-07-08 7:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a071bbe-a23b-4a2e-a772-a70b46eac970@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox