From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: ti-omap: convert text based binding to json schema
Date: Mon, 19 May 2025 18:06:30 +0200 [thread overview]
Message-ID: <6a3a7e99-8d45-4e44-8014-14d182de5dd6@kernel.org> (raw)
In-Reply-To: <20250519-ti-omap-v2-1-2a0dbc08fb9c@gmail.com>
On 19/05/2025 15:11, Charan Pedumuru wrote:
> +
> + ti,hwmods:
> + maxItems: 1
> + items:
> + type: string
That's not really correct. That's just a string, so no items, no
maxItems and use proper ref, not type string.
> + pattern: "^msdi[0-9]+$"
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> + - ti,hwmods
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-19 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 13:11 [PATCH v2] dt-bindings: mmc: ti-omap: convert text based binding to json schema Charan Pedumuru
2025-05-19 15:59 ` Conor Dooley
2025-05-20 4:36 ` Charan Pedumuru
2025-05-20 19:59 ` Rob Herring
2025-05-19 16:06 ` Krzysztof Kozlowski [this message]
2025-05-20 5:11 ` Charan Pedumuru
2025-05-20 20:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a3a7e99-8d45-4e44-8014-14d182de5dd6@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox