public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable
Date: Fri, 21 Jul 2017 11:48:31 +0300	[thread overview]
Message-ID: <6b372ca8-5777-d2f0-f4e1-bb4e55d9bcb2@intel.com> (raw)
In-Reply-To: <1500599990-170932-1-git-send-email-shawn.lin@rock-chips.com>

On 21/07/17 04:19, Shawn Lin wrote:
> It was never used and introduce a warning
> 
> drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_sdio_probe_slot':
> drivers/mmc/host/sdhci-acpi.c:297:21: warning: variable 'host' set but
> not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  drivers/mmc/host/sdhci-acpi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index ac678e9..2b1df88 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -294,13 +294,10 @@ static int sdhci_acpi_sdio_probe_slot(struct platform_device *pdev,
>  				      const char *hid, const char *uid)
>  {
>  	struct sdhci_acpi_host *c = platform_get_drvdata(pdev);
> -	struct sdhci_host *host;
>  
>  	if (!c || !c->host)
>  		return 0;
>  
> -	host = c->host;
> -
>  	/* Platform specific code during sdio probe slot goes here */
>  
>  	return 0;
> 


  reply	other threads:[~2017-07-21  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  1:19 [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable Shawn Lin
2017-07-21  8:48 ` Adrian Hunter [this message]
2017-07-27 14:48 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b372ca8-5777-d2f0-f4e1-bb4e55d9bcb2@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox