* [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable
@ 2017-07-21 1:19 Shawn Lin
2017-07-21 8:48 ` Adrian Hunter
2017-07-27 14:48 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Shawn Lin @ 2017-07-21 1:19 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Adrian Hunter, linux-mmc, Shawn Lin
It was never used and introduce a warning
drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_sdio_probe_slot':
drivers/mmc/host/sdhci-acpi.c:297:21: warning: variable 'host' set but
not used [-Wunused-but-set-variable]
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/sdhci-acpi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index ac678e9..2b1df88 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -294,13 +294,10 @@ static int sdhci_acpi_sdio_probe_slot(struct platform_device *pdev,
const char *hid, const char *uid)
{
struct sdhci_acpi_host *c = platform_get_drvdata(pdev);
- struct sdhci_host *host;
if (!c || !c->host)
return 0;
- host = c->host;
-
/* Platform specific code during sdio probe slot goes here */
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable
2017-07-21 1:19 [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable Shawn Lin
@ 2017-07-21 8:48 ` Adrian Hunter
2017-07-27 14:48 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2017-07-21 8:48 UTC (permalink / raw)
To: Shawn Lin, Ulf Hansson; +Cc: linux-mmc
On 21/07/17 04:19, Shawn Lin wrote:
> It was never used and introduce a warning
>
> drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_sdio_probe_slot':
> drivers/mmc/host/sdhci-acpi.c:297:21: warning: variable 'host' set but
> not used [-Wunused-but-set-variable]
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-acpi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index ac678e9..2b1df88 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -294,13 +294,10 @@ static int sdhci_acpi_sdio_probe_slot(struct platform_device *pdev,
> const char *hid, const char *uid)
> {
> struct sdhci_acpi_host *c = platform_get_drvdata(pdev);
> - struct sdhci_host *host;
>
> if (!c || !c->host)
> return 0;
>
> - host = c->host;
> -
> /* Platform specific code during sdio probe slot goes here */
>
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable
2017-07-21 1:19 [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable Shawn Lin
2017-07-21 8:48 ` Adrian Hunter
@ 2017-07-27 14:48 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:48 UTC (permalink / raw)
To: Shawn Lin; +Cc: Adrian Hunter, linux-mmc@vger.kernel.org
On 21 July 2017 at 03:19, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> It was never used and introduce a warning
>
> drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_sdio_probe_slot':
> drivers/mmc/host/sdhci-acpi.c:297:21: warning: variable 'host' set but
> not used [-Wunused-but-set-variable]
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/sdhci-acpi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index ac678e9..2b1df88 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -294,13 +294,10 @@ static int sdhci_acpi_sdio_probe_slot(struct platform_device *pdev,
> const char *hid, const char *uid)
> {
> struct sdhci_acpi_host *c = platform_get_drvdata(pdev);
> - struct sdhci_host *host;
>
> if (!c || !c->host)
> return 0;
>
> - host = c->host;
> -
> /* Platform specific code during sdio probe slot goes here */
>
> return 0;
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-27 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 1:19 [PATCH] mmc: sdhci-acpi: remove unused struct sdhci_host variable Shawn Lin
2017-07-21 8:48 ` Adrian Hunter
2017-07-27 14:48 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox