public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>
Cc: linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: [PATCH v2 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios
Date: Wed, 1 Feb 2017 07:48:28 +0100	[thread overview]
Message-ID: <6c3b7dbe-fb65-b40d-2625-342e2bd48776@gmail.com> (raw)
In-Reply-To: <584e5061-d359-1436-05ee-3767a5a4b10f@gmail.com>

val isn't used in the switch clause and afterwards there's an
identical statement. So remove it.

In case of an unexpected bus width the error message indicates
the intention to set the bus width to 4 and to go on.
So remove the return statement. This return statement also
conflicts with "setting to 4" because nothing would be set
actually before returning.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
---
v2:
- added acked-by
---
 drivers/mmc/host/meson-gx-mmc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index da3cce31..38edc60d 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -379,7 +379,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	meson_mmc_clk_set(host, ios->clock);
 
 	/* Bus width */
-	val = readl(host->regs + SD_EMMC_CFG);
 	switch (ios->bus_width) {
 	case MMC_BUS_WIDTH_1:
 		bus_width = CFG_BUS_WIDTH_1;
@@ -394,7 +393,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		dev_err(host->dev, "Invalid ios->bus_width: %u.  Setting to 4.\n",
 			ios->bus_width);
 		bus_width = CFG_BUS_WIDTH_4;
-		return;
 	}
 
 	val = readl(host->regs + SD_EMMC_CFG);
-- 
2.11.0




       reply	other threads:[~2017-02-01  6:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <584e5061-d359-1436-05ee-3767a5a4b10f@gmail.com>
2017-02-01  6:48 ` Heiner Kallweit [this message]
2017-02-01  6:48 ` [PATCH v2 3/9] mmc: meson-gx: improve meson_mmc_clk_set Heiner Kallweit
2017-02-01  6:48 ` [PATCH v2 4/9] mmc: meson-gx: improve meson_mmc_irq_thread Heiner Kallweit
2017-02-03 18:03   ` Kevin Hilman
2017-02-01  6:48 ` [PATCH v2 5/9] mmc: meson-gx: improve interrupt handling Heiner Kallweit
2017-02-03 18:10   ` Kevin Hilman
2017-02-01  6:49 ` [PATCH v2 6/9] mmc: meson-gx: set max block count and request size Heiner Kallweit
2017-02-01  6:49 ` [PATCH v2 7/9] mmc: meson-gx: reduce bounce buffer size Heiner Kallweit
2017-02-03 18:18   ` Kevin Hilman
2017-02-01  6:49 ` [PATCH v2 8/9] mmc: meson-gx: remove unneeded checks in remove Heiner Kallweit
2017-02-03 18:20   ` Kevin Hilman
2017-02-01  6:49 ` [PATCH v2 9/9] mmc: meson-gx: add support for HS400 mode Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c3b7dbe-fb65-b40d-2625-342e2bd48776@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox