From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: patches@linaro.org, Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8350-sagami: Wire up SDHCI2
Date: Wed, 16 Nov 2022 09:29:02 +0100 [thread overview]
Message-ID: <7083614f-578c-7ed9-5f6b-c64718747dea@linaro.org> (raw)
In-Reply-To: <20221115172828.14372-4-konrad.dybcio@linaro.org>
On 15/11/2022 18:28, Konrad Dybcio wrote:
> Adjust regulators, add required pin setup and finally enable SDHCI2
> to get the SD Card slot going on Sagami Xperias.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../dts/qcom/sm8350-sony-xperia-sagami.dtsi | 30 ++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> index a428ce31ab4e..fdf95b763cf4 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
> @@ -312,7 +312,8 @@ pm8350c_l8: ldo8 {
> pm8350c_l9: ldo9 {
> regulator-name = "pm8350c_l9";
> regulator-min-microvolt = <2960000>;
> - regulator-max-microvolt = <3008000>;
> + /* Originally max = 3008000 but SDHCI expects 2960000 */
> + regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> @@ -558,6 +559,19 @@ &qupv3_id_2 {
> status = "okay";
> };
>
> +&sdhc_2 {
> + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_active>;
> + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_sleep>;
> + vmmc-supply = <&pm8350c_l9>;
> + vqmmc-supply = <&pm8350c_l6>;
> + no-sdio;
> + no-mmc;
> + status = "okay";
> +};
> +
> +
Only one blank line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-16 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:28 [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document SM8350 SDHCI Konrad Dybcio
2022-11-15 17:28 ` [PATCH 2/4] arm64: dts: qcom: sm8350: Add SDHCI2 Konrad Dybcio
2022-11-15 17:28 ` [PATCH 3/4] arm64: dts: qcom: sm8350-sagami: Add GPIO line names for TLMM Konrad Dybcio
2022-11-15 17:28 ` [PATCH 4/4] arm64: dts: qcom: sm8350-sagami: Wire up SDHCI2 Konrad Dybcio
2022-11-16 8:29 ` Krzysztof Kozlowski [this message]
2022-11-16 8:21 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document SM8350 SDHCI Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7083614f-578c-7ed9-5f6b-c64718747dea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).