From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3C8457E59 for ; Mon, 21 Sep 2026 08:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789980381; cv=none; b=RxM0er57VKYPeu1EDQcQRU1Qb9MI+6RVaxrbQoPwCaR4G6ET37e9Odh7+Jdbztc9EL5o5AGBpUs6syV7mIfcrDG6Xn/6muedokKecHb0g1kTFPib1NrRtiszSbmbSFUBwjiY9iQ85JdGaKPqPHJGKb/jdCGIzStRLfBHhRlmupc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789980381; c=relaxed/simple; bh=H/Oq7DCmmKlvAofUgjpQ4iEZ6GqCaDK/Q4LrOcGlYX8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YMoBkSw8NWccxsPQkmSQgZECtte1TG4KcetjwyBdjo6L0fLjsU4OAqMDKmgLRbP95Nkl3rZ3C/GUjqwRtJrbgUs71bvJWvEwYoJ6LwC4TZgmuSP6WgWmFt9VyowOKyKdWVuAtjwbPzZJG99wO11jMqScv5Zf1kzqwVWYEmFwu64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kHtH7cie; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cS+yi1VW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kHtH7cie"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cS+yi1VW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68L79rpr1624326 for ; Mon, 21 Sep 2026 08:46:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qkBaXHoqMiFvjYL8zM/mOnKS4OOJMfb5HsorDcVrhUE=; b=kHtH7cieHkVvlPt4 amzlnKDl37IMwUn9NHB4e7xhpEeyJ293VQGD5i6HA24E12l+KpTEDyY8I/EFs0Dv xYAvDI+A6eJMp0UEmRmYdW9WxPXs98Fcg8neSwBNeD2YYVqRRbqE7RQDzo8oW8ks uUF0fK7SiLd0zv42+y9VlJgffgggRTzXWA8FBd2mndCIVNWbWMtNmRi1KQyEKZ8G cuEv/0n3gWYUnzzbxXKxIworWDeYJOsuP28Sc+HQ+X1rPCdOseKB01QlXpTNOccW n9o0/rjFtjf4xavMGQbrtO40u6HnMCgegUm3rde71VoOD5AsMMtLFBg+mdjFynV3 aKMkVg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gtt3wsf81-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 08:46:18 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9392788b3f8so82578385a.2 for ; Mon, 21 Sep 2026 01:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789980377; x=1790585177; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qkBaXHoqMiFvjYL8zM/mOnKS4OOJMfb5HsorDcVrhUE=; b=cS+yi1VWCNWAefQ4zml/gM0cc1QgOA7mf0JWtvdgtTlbmAqwQW1g0uOwNU/cFWq0uM 2ameIwJ8RfH6+DSv100NLpgMBGlmNOx4JYRCJ2quGYi4aYKrRliq4fwYSCH2VwpqWPSO qtMZ7icxscUCMJL8XdCVEkC3nuxo3IbGAaqB1zxIIc7LiEOvz3m5zpn0EKFLwUdHfb0D 0iWuyacxs+kvwbrDN0ChgDnY8YxrCyqofn5fWWusTciJWspNK7HhHIES2DgUUkZ6xeeJ S6HXLLdB/RTjKyLwzi6flcv3YbSQuTkGm34dDOEwcSGx7nbLy+9SdGEbFtswE4IIgAAb dwgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789980377; x=1790585177; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qkBaXHoqMiFvjYL8zM/mOnKS4OOJMfb5HsorDcVrhUE=; b=RqbQG8Te2/LExKtKu87pPRpR9E+tGiViJJPaHG4nl8nPrCfdQHCmO1brbGjeRJ5pB8 WWHd6v188GtN4riBkK1hO9wIUug7YPOa2im+vxNlFjZM9vuHXDRuGQCIagZKwELzTLyZ 9lYS1CMDx808+jwlRwRwilDulBcRFgeAKYb6XTgWsJxLF53hRBWgwrdZ31LMYwszSa9v A7W2zPjgnoKjGr3LNH0Hwkkkn9XDHDwzZqVv9WQeZJ5zIz9qPnZLocjmtVBYMdkURV8Z 53GIN0nynO5/8+eXm4csL7+ESGZufdKoJT/5+JNn5M1Qj6WfuEkJPc2LoabKn8KVDawt ZDYA== X-Forwarded-Encrypted: i=1; AKwUvBxn3bUtvRGd+npxRULz7L1s/ObUNz2RRQObRHBrMkSW+NmGpVbKkGocKXLU0r5C2j+Ek6MCGvqePv4=@vger.kernel.org X-Gm-Message-State: AFuF++ksjYUxMALguAWVf/K+0Epcc624ppwERNXL/my1Q+N4JXO8bJHZ ulMlZMVbzUrEjocGbG0hPwXFLWXXiSaJqaEx3xFuNxiUwC8C3W4skdsPEE66TuW8U1Ce7h6lirm zjE3OpmszMw2P0JXKE2aYzRI+QhiEYp70WF2eBhkVmt2IC2AYgVTr0mawzdwNgWg= X-Gm-Gg: AYBFou1myae+aaPPLQciK7WPFJd6wTilrB2hDd2mQRjaTn4k3k+Y++bZvtaqLPXYowx B4TuYBxfnrT2ol2bGSgzD7359HQL/WG9gLRO5+itVc6WJ/5NRbU25LtWV29/DepwDOua7GVeO6a Xi1UrF6qQB8iLP8tFeW/wr3mo85ZSp1DUUUAiIWwo7qarAF0Tdqd8mVJlq7a9MPIicDnDjbr8we 67+ffw3gXkahu+vFSlUV29zXFl+FTS9WHqtCh7/g6MxinYhRZiMIiMZMMTf6Ixl/PexjREbTp78 hMua6RHo+MJfYYqSdEbqMUXLIN7Ov6Mojto99mMA44muvTElnHtQmFUl/UBE4WA0/WvwbRoEuI8 sRwYz4y56LYDlgS4ZcCJQWA== X-Received: by 2002:a05:620a:1729:b0:93b:c6ec:780d with SMTP id af79cd13be357-93bf57df974mr940253385a.5.1789980377379; Mon, 21 Sep 2026 01:46:17 -0700 (PDT) X-Received: by 2002:a05:620a:1729:b0:93b:c6ec:780d with SMTP id af79cd13be357-93bf57df974mr940246585a.5.1789980376913; Mon, 21 Sep 2026 01:46:16 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a358ade5asm270916366b.51.2026.09.21.01.46.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 01:46:15 -0700 (PDT) Message-ID: <733a3b6c-4278-405a-be52-0bd22ad1584d@oss.qualcomm.com> Date: Mon, 21 Sep 2026 10:46:09 +0200 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/19] clk: qcom: Add global clock controller driver for MSM8952 To: Muzaffer Kadir , Taniya Das Cc: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Ulf Hansson , Konrad Dybcio , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Lee Jones , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Robert Marko , Guru Das Srinagesh , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Dmitry Torokhov , David Heidelberg , Dang Huynh , phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, iommu@lists.linux.dev, mfd@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-input@vger.kernel.org References: <20260916-msm8952-initial-support-v2-0-798c2602dde1@mainlining.org> <20260916-msm8952-initial-support-v2-2-798c2602dde1@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDEyNSBTYWx0ZWRfXyT/UQ1iZgzWw WpQe8AsXJ35UXrnr6Ce9WNNaGeJN60Nkh2GQs3Is2YdEC+hoqbMNW2ggiXIn6De/w0C1k35DUne cB3DMJK4i+ATuhFf+yq9ZbkU7nQmx75lMwzZT0xmbhbVK15pY1csWUZMTIhzktQYzADvwXg0MlZ FqmveKKMPJEBHpD3IQtv+NPa5keMKYdAqFDlQ4iD5PiyebCyxxS0/oYMCILTnb/bXyjrE/w5r73 Y/poUpQvTGn6h1S5OGp/Wml08OxTkN9xawrT73pCaGbyCm6nARxcyLj8Mo+bt6eD1/+Up2SUIoB pLdsz+Rb8/nFEE/bAG337Bp97JQckpNmZ9Mr84J9MxCFbCcq73GyJWTATPwc0Y0CnD3zgouPa5K RP1C4S0lqePcP8f2yN9hFiL8KcLFtK02vrq3RA7TtFR7+Q7xxHVZ3MOSDOx+H20AHLB08es510d f6rOO92m+6l3XRuzHpA== X-Proofpoint-ORIG-GUID: X_IS7msjaajvgwG-QimCPtKm8k4geOiu X-Proofpoint-GUID: X_IS7msjaajvgwG-QimCPtKm8k4geOiu X-Authority-Analysis: v=2.4 cv=dakVTnXe c=1 sm=1 tr=0 ts=6ab0eeda cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=IpRBMZr9S9mwpYgRR9UA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDEyNSBTYWx0ZWRfXxPlqrX2dTD01 hfNj46g5khAgM64Dldha4KhecS8ZphNXlEnWRTjYMJdNAVwaLeeJ0uY3LnDmfxvJTPCYD4sfGeF c5u/8sUGXs51CoK3F8Eh7EWMVNf838w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210125 On 9/17/26 2:25 PM, Muzaffer Kadir wrote: > Hi Taniya, > > On Thu, 17 Sep 2026 09:49:07 +0530, Taniya Das wrote: >>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >>> index a6c676f68b79..3c3f27dcc68d 100644 [...] >>> +#include "common.h" >>> +#include "clk-regmap.h" >>> +#include "clk-pll.h" >>> +#include "clk-alpha-pll.h" >>> +#include "clk-rcg.h" >>> +#include "clk-branch.h" >>> +#include "reset.h" >>> +#include "gdsc.h" >>> + >> >> Add DT_BI_TCXO enum. > > Should I rename the clock name to bi_tcxo? > Or should I use DT_XO for enum? BI_TCXO is the Qualcomm-conventional name for the clock sourced from the crystal oscillator. I'm not sure about the BI_ prefix, but TCXO stands for "Temperature-Controlled Crystal Oscillator" Konrad