From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B079BEB64DD for ; Thu, 13 Jul 2023 08:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234516AbjGMIRw (ORCPT ); Thu, 13 Jul 2023 04:17:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234393AbjGMIRP (ORCPT ); Thu, 13 Jul 2023 04:17:15 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0202749C7 for ; Thu, 13 Jul 2023 01:11:23 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fb4146e8ceso3363605e9.0 for ; Thu, 13 Jul 2023 01:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689235878; x=1691827878; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yb8d44+Azm1wudWtAn5xRkTck24UWL//WFKAbn+rUfU=; b=ascpkzLoPhhIgMmmEAEN6xdJt6oqEZdzliI5wE3gQb4AXxeOQldD1FYpjShjUe07oP MR8YE4EfOFtWYedwzGgQ1/0b5AHlXXu10s305WYBf9dGp1xBPkLl3glMb/oYXQG0BMrK 4vaQux0LTz/IYS0tKb0ZBhM3WRhxT6n7LMdU1S0eaVj1lGFVIRpZAT17PWXGr1c8iVUz gKktxCb1KqwQ7XQ4qemWMOIwWYjjX1M9P5fqi2KitWoS3YrMUVOJbudikcjnBEDVx7tC vfI4xScCVshFZbi/nZnhVKtMLLCwG3TAQyitknHiE4ap5tuTFyTHJter+X5nk2hPO2uJ fRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689235878; x=1691827878; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yb8d44+Azm1wudWtAn5xRkTck24UWL//WFKAbn+rUfU=; b=RbAGQudHypbnzgJ7OYIn32CT8V9E74ddrL87fbpkxlpb+rpYj4zOK1QMgmR7WzAeZy n5VcMHci1KfCkQKbYMQw5Ne4yZeRxEUbmAAWci1bNYC/knsVz25yHcbok5Ew90kH6PV7 RxLzM81oTp5OkFfA2GLDWNdSvt5/6jYj4020B2QknqL2t/qCtkCQQJiAJOvaWYNenDr6 1fySntPCAp4cOuzDdLSuGu5Ilhm04D8FpxEVdilqzzpEiSfAW63bGWJCdFv1Ft7Htee2 fGDXJJoeB3ilJBCRSraFiNxj4pQh3cIJbid5qE6Dow2w8F7nOlnbRDlV6qt9cOnZZPeI 1ApQ== X-Gm-Message-State: ABy/qLaDnnlFrldRqGXzfd9V0+mc8CCez9X8HF3ZHjW/WhKS00/1pTRB qTmp/oSyZhx7qiqihm3ZmxSTJlie+USgW6Pok6xJng== X-Google-Smtp-Source: APBJJlEdublQH/URkoiDZqIG/L0SD2i5TgW5g+DYrQXBYFGXmThM0kaDm7NuUOXNoZ6JaeW2aokOiw== X-Received: by 2002:a05:600c:20f:b0:3f9:b87c:10db with SMTP id 15-20020a05600c020f00b003f9b87c10dbmr694751wmi.3.1689235878121; Thu, 13 Jul 2023 01:11:18 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id q4-20020adfcd84000000b0031134bcdacdsm7240492wrj.42.2023.07.13.01.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 01:11:17 -0700 (PDT) Message-ID: <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org> Date: Thu, 13 Jul 2023 10:11:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove callback returning void To: Yangtao Li , Jaehoon Chung , Ulf Hansson , Alim Akhtar Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230713080807.69999-1-frank.li@vivo.com> <20230713080807.69999-14-frank.li@vivo.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230713080807.69999-14-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 13/07/2023 10:07, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. You even copied Uwe's commit msg... Aren't you duplicate his work or is it being coordinated? Best regards, Krzysztof