Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

Russell King - ARM Linux
2013-02-09T20:08:50Z

On Sat, Feb 09, 2013 at 09:35:53PM +0530, Sekhar Nori wrote:
> On 2/1/2013 11:52 PM, Matt Porter wrote:
> > + ret = of_address_to_resource(node, 1, &res);
>
> of_address_to_resource() needs <linux/of_address.h>
>
> > + if (IS_ERR_VALUE(ret))
>
> This needs <linux/err.h>

More importantly, is this the correct way to check for errors from
of_address_to_resource() ? Grepping the source shows that either less
than 0 or non-zero are the commonly used conditions here.