From: arvind Yadav <arvind.yadav.cs@gmail.com>
To: jh80.chung@samsung.com, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v1] mmc: host: dw_mmc-pci:- Handle return NULL error from pcim_iomap_table
Date: Thu, 22 Dec 2016 22:42:49 +0530 [thread overview]
Message-ID: <7735ce5d-643a-1e8a-1f13-0ea24cc4b65b@gmail.com> (raw)
In-Reply-To: <1482408409-13404-1-git-send-email-arvind.yadav.cs@gmail.com>
Ignore this change. Sorry for noise.
Thanks
-Arvind
On Thursday 22 December 2016 05:36 PM, Arvind Yadav wrote:
> Here, If pcim_iomap_table will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference.
> This error check will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mmc/host/dw_mmc-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
> index ab82796..f42d302 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -61,6 +61,8 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
> return ret;
>
> host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
> + if (!host->regs)
> + return -ENOMEM;
>
> pci_set_master(pdev);
>
prev parent reply other threads:[~2016-12-22 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 12:06 [v1] mmc: host: dw_mmc-pci:- Handle return NULL error from pcim_iomap_table Arvind Yadav
2016-12-22 17:12 ` arvind Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7735ce5d-643a-1e8a-1f13-0ea24cc4b65b@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox