Re: [PATCH] mmc: sdhci-of-dwcmshc: check bus clock enable result in the, probe() method

[Sergey Shtylyov <s.shtylyov@auroraos.dev>]

On 5/28/26 11:42 PM, Sergey Shtylyov wrote:

> In the driver's probe() method, clk_disable_unprepare() for the bus clock
> is called on the error path even if the prior clk_prepare_enable() call has
> failed -- that causes the prepare/enable counter imbalance.  Also, the same

   I missed the fact that the remove() would be affected by the imbalance as well.
I'll update the description and repost...

> kind of problem can happen in the driver's suspend() method; note that the
> resume() method does check for the clk_prepare_enable()'s success -- let's
> just be consistent and do that in probe() method too (BTW, I don't know for
> sure what does the bus clock control -- if it affects the register access,
> the driver is likely to cause a kernel oops iff it fails to prepare/enable
> the bus clock in the probe() method)...
> 
> Found by Linux Verification Center (linuxtesting.org) with the Svace static
> analysis tool.
> 
> Fixes: e438cf49b305 ("mmc: sdhci-of-dwcmshc: add SDHCI OF Synopsys DWC MSHC driver")
> Fixes: bccce2ec7790 ("mmc: sdhci-of-dwcmshc: add suspend/resume support")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
[...]

MBR, Sergey