From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Wenchao Chen <wenchao.chen@unisoc.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-sprd: Fix error code in sdhci_sprd_tuning()
Date: Tue, 12 Sep 2023 09:16:32 +0800 [thread overview]
Message-ID: <7c4a8e50-499c-ec13-536b-42ee951f58c3@linux.alibaba.com> (raw)
In-Reply-To: <a8af0a08-8405-43cc-bd83-85ff25f572ca@moroto.mountain>
On 9/7/2023 5:54 PM, Dan Carpenter wrote:
> Return an error code if sdhci_sprd_get_best_clk_sample() fails.
> Currently, it returns success.
>
> Fixes: d83d251bf3c2 ("mmc: sdhci-sprd: Add SD HS mode online tuning")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> This is from static analysis and has not been tested.
> ---
> drivers/mmc/host/sdhci-sprd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 649ae075e229..6b84ba27e6ab 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -644,6 +644,7 @@ static int sdhci_sprd_tuning(struct mmc_host *mmc, struct mmc_card *card,
> best_clk_sample = sdhci_sprd_get_best_clk_sample(mmc, value);
> if (best_clk_sample < 0) {
> dev_err(mmc_dev(host->mmc), "all tuning phase fail!\n");
> + err = best_clk_sample;
> goto out;
> }
>
next prev parent reply other threads:[~2023-09-12 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:54 [PATCH] mmc: sdhci-sprd: Fix error code in sdhci_sprd_tuning() Dan Carpenter
2023-09-08 7:30 ` Chunyan Zhang
2023-09-08 8:37 ` Wenchao Chen
2023-09-12 1:16 ` Baolin Wang [this message]
2023-09-12 9:41 ` Adrian Hunter
2023-09-14 14:47 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c4a8e50-499c-ec13-536b-42ee951f58c3@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=adrian.hunter@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wenchao.chen@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox