From: Patrice CHOTARD <patrice.chotard@st.com>
To: Jisheng Zhang <jszhang@marvell.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@stlinux.com" <kernel@stlinux.com>
Subject: Re: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call
Date: Fri, 10 Mar 2017 08:40:10 +0000 [thread overview]
Message-ID: <7e8b38e3-16a3-b00d-b30b-e24aa0f9d85a@st.com> (raw)
In-Reply-To: <20170310031733.812-4-jszhang@marvell.com>
Hi Jisheng
On 03/10/2017 04:17 AM, Jisheng Zhang wrote:
> sdhci_pltfm_init() has already set the platform drvdata for us, remove
> the unnecessary platform_set_drvdata() call.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/mmc/host/sdhci-st.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index ed92ce729dde..7fff6490855c 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - platform_set_drvdata(pdev, host);
> -
> host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION));
>
> dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n",
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
next prev parent reply other threads:[~2017-03-10 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 3:17 [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call Jisheng Zhang
2017-03-10 3:17 ` [PATCH 1/3] mmc: sdhci-pxav3: " Jisheng Zhang
2017-03-10 3:17 ` [PATCH 2/3] mmc: sdhci-pxav2: " Jisheng Zhang
2017-03-10 3:17 ` [PATCH 3/3] mmc: sdhci-st: " Jisheng Zhang
2017-03-10 8:40 ` Patrice CHOTARD [this message]
2017-03-16 14:46 ` [PATCH 0/3] mmc: sdhci: " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e8b38e3-16a3-b00d-b30b-e24aa0f9d85a@st.com \
--to=patrice.chotard@st.com \
--cc=adrian.hunter@intel.com \
--cc=jszhang@marvell.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox