From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A073C43334 for ; Mon, 4 Jul 2022 02:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbiGDCdw (ORCPT ); Sun, 3 Jul 2022 22:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbiGDCdv (ORCPT ); Sun, 3 Jul 2022 22:33:51 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068D4638F; Sun, 3 Jul 2022 19:33:47 -0700 (PDT) X-UUID: 1c3b8c12367841b8ae02986da5c98c8e-20220704 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.7,REQID:8b6b6084-27d5-4bb8-8d25-a02f97a42e01,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.7,REQID:8b6b6084-27d5-4bb8-8d25-a02f97a42e01,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:87442a2,CLOUDID:45a24d63-0b3f-4b2c-b3a6-ed5c044366a0,C OID:26c946f04d04,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 1c3b8c12367841b8ae02986da5c98c8e-20220704 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 577633664; Mon, 04 Jul 2022 10:33:43 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 4 Jul 2022 10:33:42 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 4 Jul 2022 10:33:41 +0800 Message-ID: <81a77333a0b2f9186ce6cb94e3b4e1c815b07843.camel@mediatek.com> Subject: Re: [PATCH v13 3/3] mmc: mediatek: add support for SDIO eint wakup IRQ From: Axe Yang To: Ulf Hansson , Rob Herring , Chaotian Jing , Matthias Brugger , Adrian Hunter CC: Yoshihiro Shimoda , Satya Tangirala , Andy Shevchenko , Wolfram Sang , Lucas Stach , Eric Biggers , Andrew Jeffery , Stephen Boyd , Kiwoong Kim , Yue Hu , Tian Tao , , , , , , , , Yong Mao Date: Mon, 4 Jul 2022 10:33:40 +0800 In-Reply-To: <20220623090445.1401-4-axe.yang@mediatek.com> References: <20220623090445.1401-1-axe.yang@mediatek.com> <20220623090445.1401-4-axe.yang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi, Gentle ping for this patch. With Regards, Axe On Thu, 2022-06-23 at 17:04 +0800, Axe Yang wrote: > Add support for eint IRQ when MSDC is used as an SDIO host. This > feature requires SDIO device support async IRQ function. With this > feature, SDIO host can be awakened by SDIO card in suspend state, > without additional pin. > > MSDC driver will time-share the SDIO DAT1 pin. During suspend, MSDC > turn off clock and switch SDIO DAT1 pin to GPIO mode. And during > resume, switch GPIO function back to DAT1 mode then turn on clock. > > Some device tree property should be added or modified in MSDC node > to support SDIO eint IRQ. Pinctrls "state_eint" is mandatory. Since > this feature depends on asynchronous interrupts, "wakeup-source", > "keep-power-in-suspend" and "cap-sdio-irq" flags are necessary, and > the interrupts list should be extended(the interrupt named with > sdio_wakeup): > &mmcX { > ... > interrupt-names = "msdc", "sdio_wakeup"; > interrupts-extended = <...>, > <&pio xxx > IRQ_TYPE_LEVEL_LOW>; > ... > pinctrl-names = "default", "state_uhs", "state_eint"; > ... > pinctrl-2 = <&mmc2_pins_eint>; > ... > cap-sdio-irq; > keep-power-in-suspend; > wakeup-source; > ... > }; > > Co-developed-by: Yong Mao > Signed-off-by: Yong Mao > Signed-off-by: Axe Yang > --- > drivers/mmc/host/mtk-sd.c | 84 ++++++++++++++++++++++++++++++++++++- > -- > 1 file changed, 78 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 195dc897188b..f907b96cfd87 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2014-2015 MediaTek Inc. > + * Copyright (c) 2014-2015, 2022 MediaTek Inc. > * Author: Chaotian.Jing > */ > > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -440,8 +441,10 @@ struct msdc_host { > struct pinctrl *pinctrl; > struct pinctrl_state *pins_default; > struct pinctrl_state *pins_uhs; > + struct pinctrl_state *pins_eint; > struct delayed_work req_timeout; > int irq; /* host interrupt */ > + int eint_irq; /* interrupt from sdio device for > waking up system */ > struct reset_control *reset; > > struct clk *src_clk; /* msdc source clock */ > @@ -1520,17 +1523,46 @@ static void __msdc_enable_sdio_irq(struct > msdc_host *host, int enb) > > static void msdc_enable_sdio_irq(struct mmc_host *mmc, int enb) > { > - unsigned long flags; > struct msdc_host *host = mmc_priv(mmc); > + unsigned long flags; > + int ret; > > spin_lock_irqsave(&host->lock, flags); > __msdc_enable_sdio_irq(host, enb); > spin_unlock_irqrestore(&host->lock, flags); > > - if (enb) > - pm_runtime_get_noresume(host->dev); > - else > - pm_runtime_put_noidle(host->dev); > + if (mmc_card_enable_async_irq(mmc->card) && host->pins_eint) { > + if (enb) { > + /* > + * In dev_pm_set_dedicated_wake_irq_reverse(), > eint pin will be set to > + * GPIO mode. We need to restore it to SDIO > DAT1 mode after that. > + * Since the current pinstate is pins_uhs, to > ensure pinctrl select take > + * affect successfully, we change the pinstate > to pins_eint firstly. > + */ > + pinctrl_select_state(host->pinctrl, host- > >pins_eint); > + ret = > dev_pm_set_dedicated_wake_irq_reverse(host->dev, host->eint_irq); > + > + if (ret) { > + dev_err(host->dev, "Failed to register > SDIO wakeup irq!\n"); > + host->pins_eint = NULL; > + pm_runtime_get_noresume(host->dev); > + } else { > + dev_dbg(host->dev, "SDIO eint irq: > %d!\n", host->eint_irq); > + } > + > + pinctrl_select_state(host->pinctrl, host- > >pins_uhs); > + } else { > + dev_pm_clear_wake_irq(host->dev); > + } > + } else { > + if (enb) { > + /* Ensure host->pins_eint is NULL */ > + host->pins_eint = NULL; > + pm_runtime_get_noresume(host->dev); > + } else { > + pm_runtime_put_noidle(host->dev); > + } > + } > } > > static irqreturn_t msdc_cmdq_irq(struct msdc_host *host, u32 intsts) > @@ -2631,6 +2663,20 @@ static int msdc_drv_probe(struct > platform_device *pdev) > goto host_free; > } > > + /* Support for SDIO eint irq ? */ > + if ((mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ) && (mmc->pm_caps & > MMC_PM_KEEP_POWER)) { > + host->eint_irq = platform_get_irq_byname(pdev, > "sdio_wakeup"); > + if (host->eint_irq > 0) { > + host->pins_eint = pinctrl_lookup_state(host- > >pinctrl, "state_eint"); > + if (IS_ERR(host->pins_eint)) { > + dev_err(&pdev->dev, "Cannot find > pinctrl eint!\n"); > + host->pins_eint = NULL; > + } else { > + device_init_wakeup(&pdev->dev, true); > + } > + } > + } > + > msdc_of_property_parse(pdev, host); > > host->dev = &pdev->dev; > @@ -2845,6 +2891,13 @@ static int __maybe_unused > msdc_runtime_suspend(struct device *dev) > struct msdc_host *host = mmc_priv(mmc); > > msdc_save_reg(host); > + > + if (host->pins_eint) { > + disable_irq(host->irq); > + pinctrl_select_state(host->pinctrl, host->pins_eint); > + if (sdio_irq_claimed(mmc)) > + __msdc_enable_sdio_irq(host, 0); > + } > msdc_gate_clock(host); > return 0; > } > @@ -2860,12 +2913,18 @@ static int __maybe_unused > msdc_runtime_resume(struct device *dev) > return ret; > > msdc_restore_reg(host); > + > + if (host->pins_eint) { > + pinctrl_select_state(host->pinctrl, host->pins_uhs); > + enable_irq(host->irq); > + } > return 0; > } > > static int __maybe_unused msdc_suspend(struct device *dev) > { > struct mmc_host *mmc = dev_get_drvdata(dev); > + struct msdc_host *host = mmc_priv(mmc); > int ret; > > if (mmc->caps2 & MMC_CAP2_CQE) { > @@ -2874,11 +2933,24 @@ static int __maybe_unused msdc_suspend(struct > device *dev) > return ret; > } > > + /* > + * Bump up runtime PM usage counter otherwise dev- > >power.needs_force_resume will > + * not be marked as 1, pm_runtime_force_resume() will go out > directly. > + */ > + if (host->pins_eint) > + pm_runtime_get_noresume(dev); > + > return pm_runtime_force_suspend(dev); > } > > static int __maybe_unused msdc_resume(struct device *dev) > { > + struct mmc_host *mmc = dev_get_drvdata(dev); > + struct msdc_host *host = mmc_priv(mmc); > + > + if (host->pins_eint) > + pm_runtime_put_noidle(dev); > + > return pm_runtime_force_resume(dev); > } >