From: Ulrich Hecht <uli@fpond.eu>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa@kernel.org>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: RE: [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit
Date: Mon, 2 Aug 2021 13:18:18 +0200 (CEST) [thread overview]
Message-ID: <821963380.577567.1627903098435@webmail.strato.com> (raw)
In-Reply-To: <TY2PR01MB3692486033934E1C007EBF6AD8EF9@TY2PR01MB3692.jpnprd01.prod.outlook.com>
> On 08/02/2021 7:34 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
>
>
> Hi Wolfram-san, Ulrich-san,
>
> > From: Wolfram Sang, Sent: Saturday, July 31, 2021 12:28 AM
> >
> > On Fri, May 14, 2021 at 05:53:18PM +0200, Ulrich Hecht wrote:
> > > The TMIO core sets a very low latency limit (100 us), but when using R-Car
> > > SDHI hosts with SD cards, I have observed typical latencies of around 20-30
> > > ms. This prevents runtime PM from working properly, and the devices remain
> > > on continuously.
> > >
> > > This patch sets the default latency limit to 100 ms to avoid that.
> > >
> > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
> >
> > Adding Shimoda-san to CC.
> >
> > Shimoda-san: can you kindly run your SDHI tests with this patch applied?
>
> Sure!
>
> However, I have a question about this patch.
> Would you know how to measure the latencies?
IIRC I simply put a printk() in default_suspend_ok() that dumps td->suspend_latency_ns and td->resume_latency_ns.
> I enabled function trace of rpm and checked the log, but I could not observe
> any behavior changes with and without applying this patch.
So you are saying that for you, the clock is suspended as expected when removing the card, even without this patch?
If so, I wonder if there are variations between boards...
CU
Uli
next prev parent reply other threads:[~2021-08-02 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 15:53 [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit Ulrich Hecht
2021-05-19 14:25 ` Wolfram Sang
2021-06-02 15:40 ` Ulrich Hecht
2021-06-18 8:17 ` Wolfram Sang
2021-06-18 10:40 ` Wolfram Sang
2021-06-30 4:44 ` Wolfram Sang
2021-07-30 15:28 ` Wolfram Sang
2021-08-02 5:34 ` Yoshihiro Shimoda
2021-08-02 11:18 ` Ulrich Hecht [this message]
2021-08-03 11:16 ` Yoshihiro Shimoda
2021-08-04 5:29 ` Yoshihiro Shimoda
2021-08-04 16:17 ` Ulrich Hecht
2021-08-02 12:53 ` Wolfram Sang
2021-08-03 11:16 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821963380.577567.1627903098435@webmail.strato.com \
--to=uli@fpond.eu \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox