From: Adrian Hunter <adrian.hunter@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg
Date: Thu, 9 Oct 2025 09:11:05 +0300 [thread overview]
Message-ID: <82b1d733-df39-4f20-8f69-69b34bfac3b5@intel.com> (raw)
In-Reply-To: <20251008-mmc-no-advert-v2-1-45bc00006fb2@linaro.org>
On 08/10/2025 01:04, Linus Walleij wrote:
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
>
> Drop all messages from sdhci_drv_init().
>
> We need to keep the module_init/exit() calls to stub
> functions for the module to work according to
> <linux/module.h>.
But is that true?
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
> drivers/mmc/host/sdhci.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af71fa5a70eb579fd812227b9347f83..2025b33bd6bfb51fc3116148299807054179b2e2 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4999,10 +4999,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>
> static int __init sdhci_drv_init(void)
> {
> - pr_info(DRIVER_NAME
> - ": Secure Digital Host Controller Interface driver\n");
> - pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
> return 0;
> }
>
>
> ---
> base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
>
> Best regards,
next prev parent reply other threads:[~2025-10-09 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 22:04 [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg Linus Walleij
2025-10-09 6:11 ` Adrian Hunter [this message]
2025-10-13 13:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b1d733-df39-4f20-8f69-69b34bfac3b5@intel.com \
--to=adrian.hunter@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).