eMMC bus test command failure

eMMC bus test command failure

[Minjian Wu (minjianwu)]

Hi,
    
	I got one issue on Linux V3.7 as following.
         > mmc0: switch to bus width 1 ddr 0 failed 
         > mmc0: error -110 whilst initialising MMC card

         After debugging and checking the source codes, we find that in mmc_send_bus_test function, there is no data timeout setting(mmc_set_data_timeout). After we add the timeout setting function, this issue is fixed, could you help confirm it? Thank you!




Best Regards, 

Re: eMMC bus test command failure

[Chris Ball]

Hi Minjian,

On Sun, May 26 2013, Minjian Wu (minjianwu) wrote:
> Hi,
>
> 	I got one issue on Linux V3.7 as following.
>          > mmc0: switch to bus width 1 ddr 0 failed 
>          > mmc0: error -110 whilst initialising MMC card
>
>          After debugging and checking the source codes, we find that
> in mmc_send_bus_test function, there is no data timeout
> setting(mmc_set_data_timeout). After we add the timeout setting
> function, this issue is fixed, could you help confirm it? Thank you!

Please could you submit the patch you used?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

RE: eMMC bus test command failure

[Minjian Wu (minjianwu)]

Hi Chris,
	Sorry for the late response. Below is the patch based on Linux 3.8.4. Please help to check it. Thanks!

diff --git a/linux-3.8.4/drivers/mmc/core/mmc_ops.c b/linux-3.8_new/drivers/mmc/
index 6d8f701..a3ca845 100644
--- a/linux-3.8.4/drivers/mmc/core/mmc_ops.c
+++ b/linux-3.8_new/drivers/mmc/core/mmc_ops.c
@@ -560,6 +560,7 @@ mmc_send_bus_test(struct mmc_card *card, struct mmc_host *ho
        else
                data.flags = MMC_DATA_WRITE;
 
+       mmc_set_data_timeout(&data,card);
        data.sg = &sg;
        data.sg_len = 1;
        sg_init_one(&sg, data_buf, len);




-----Original Message-----
From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Chris Ball
Sent: Thursday, June 27, 2013 10:52 PM
To: Minjian Wu (minjianwu)
Cc: linux-mmc@vger.kernel.org
Subject: Re: eMMC bus test command failure

Hi Minjian,

On Sun, May 26 2013, Minjian Wu (minjianwu) wrote:
> Hi,
>
> 	I got one issue on Linux V3.7 as following.
>          > mmc0: switch to bus width 1 ddr 0 failed 
>          > mmc0: error -110 whilst initialising MMC card
>
>          After debugging and checking the source codes, we find that
> in mmc_send_bus_test function, there is no data timeout
> setting(mmc_set_data_timeout). After we add the timeout setting
> function, this issue is fixed, could you help confirm it? Thank you!

Please could you submit the patch you used?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: eMMC bus test command failure

[Minjian Wu (minjianwu)]

Hi Chris,
	Could you let me know how about this fix? Thank you!

-----Original Message-----
From: Minjian Wu (minjianwu) 
Sent: Monday, July 08, 2013 3:28 PM
To: 'Chris Ball'
Cc: linux-mmc@vger.kernel.org
Subject: RE: eMMC bus test command failure

Hi Chris,
	Sorry for the late response. Below is the patch based on Linux 3.8.4. Please help to check it. Thanks!

diff --git a/linux-3.8.4/drivers/mmc/core/mmc_ops.c b/linux-3.8_new/drivers/mmc/
index 6d8f701..a3ca845 100644
--- a/linux-3.8.4/drivers/mmc/core/mmc_ops.c
+++ b/linux-3.8_new/drivers/mmc/core/mmc_ops.c
@@ -560,6 +560,7 @@ mmc_send_bus_test(struct mmc_card *card, struct mmc_host *ho
        else
                data.flags = MMC_DATA_WRITE;
 
+       mmc_set_data_timeout(&data,card);
        data.sg = &sg;
        data.sg_len = 1;
        sg_init_one(&sg, data_buf, len);




-----Original Message-----
From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Chris Ball
Sent: Thursday, June 27, 2013 10:52 PM
To: Minjian Wu (minjianwu)
Cc: linux-mmc@vger.kernel.org
Subject: Re: eMMC bus test command failure

Hi Minjian,

On Sun, May 26 2013, Minjian Wu (minjianwu) wrote:
> Hi,
>
> 	I got one issue on Linux V3.7 as following.
>          > mmc0: switch to bus width 1 ddr 0 failed 
>          > mmc0: error -110 whilst initialising MMC card
>
>          After debugging and checking the source codes, we find that
> in mmc_send_bus_test function, there is no data timeout
> setting(mmc_set_data_timeout). After we add the timeout setting
> function, this issue is fixed, could you help confirm it? Thank you!

Please could you submit the patch you used?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: eMMC bus test command failure

[Chris Ball]

Hi Minjian,

On Wed, Jul 24 2013, Minjian Wu (minjianwu) wrote:
> Hi Chris,
> 	Could you let me know how about this fix? Thank you!

Could you send me a Signed-off-by line for the patch, please?
You can read more about this here (section 12):

https://www.kernel.org/doc/Documentation/SubmittingPatches

Thanks!

- Chris.
-- 
Chris Ball   <chris@printf.net>   <http://printf.net/>