From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd Date: Fri, 17 Jan 2014 14:25:30 +0000 Message-ID: <867g9y8z39.fsf@void.printf.net> References: <1389839502-13046-1-git-send-email-zhangfei.gao@linaro.org> <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> <87y52fok4r.fsf@linaro.org> <003401cf1380$a194aa10$e4bdfe30$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:38651 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbaAQOZk (ORCPT ); Fri, 17 Jan 2014 09:25:40 -0500 In-Reply-To: <003401cf1380$a194aa10$e4bdfe30$%jun@samsung.com> (Seungwon Jeon's message of "Fri, 17 Jan 2014 21:35:40 +0900") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: 'Kevin Hilman' , 'Zhangfei Gao' , 'Russell King - ARM Linux' , 'Sachin Kamat' , 'Arnd Bergmann' , 'Mike Turquette' , 'Jaehoon Chung' , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org Hi, On Fri, Jan 17 2014, Seungwon Jeon wrote: > On Fri, January 17, 2014, Kevin Hilman wrote: >> Zhangfei Gao writes: >> >> > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b >> > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc) >> > can not be checked by IS_ERR_VALUE. >> > Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT, >> > otherwise sd detect may occasionally fail. >> > >> > Signed-off-by: Zhangfei Gao >> > Reported-by: Kevin Hilman >> > Reviewed-by: Sachin Kamat >> > Tested-by: Sachin Kamat >> >> I didn't look at the patch in detail, but can at least confirm that >> Arndale boots again in -next with this patch applied. >> >> Tested-by: Kevin Hilman > > Acked-by: Seungwon Jeon Thanks, pushed to mmc-next for 3.14. - Chris. -- Chris Ball