* [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists
@ 2014-06-04 19:08 Chris Ball
2014-06-04 22:56 ` Jaehoon Chung
0 siblings, 1 reply; 3+ messages in thread
From: Chris Ball @ 2014-06-04 19:08 UTC (permalink / raw)
To: linux-mmc; +Cc: Ulf Hansson, Jaehoon Chung, Kyungmin Park, Tomasz Figa
"mmc: sdhci: push card_tasklet into threaded irq handler" removed
the card_tasklet, but it is still in use by sdhci-s3c.c.
Signed-off-by: Chris Ball <chris@printf.net>
---
Hi,
sdhci-s3c is currently failing to build due to the removal of
card_tasklet. I think this trivial patch might do the right
thing -- please could someone test that card detection still
works and ACK if so? Thanks!
drivers/mmc/host/sdhci-s3c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 781b8a9..53a32e2 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
clk_disable_unprepare(sc->clk_io);
#endif
}
- tasklet_schedule(&host->card_tasklet);
spin_unlock_irqrestore(&host->lock, flags);
}
}
--
Chris Ball <http://printf.net/>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists
2014-06-04 19:08 [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists Chris Ball
@ 2014-06-04 22:56 ` Jaehoon Chung
2014-06-05 2:13 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2014-06-04 22:56 UTC (permalink / raw)
To: Chris Ball, linux-mmc; +Cc: Ulf Hansson, Kyungmin Park, Tomasz Figa
Hi, Chris.
Didn't you want to merge the below patch?
https://patchwork.kernel.org/patch/4239541/
I have tested with exynos series, and working fine.
Best Regards,
Jaehoon Chung
On 06/05/2014 04:08 AM, Chris Ball wrote:
> "mmc: sdhci: push card_tasklet into threaded irq handler" removed
> the card_tasklet, but it is still in use by sdhci-s3c.c.
>
> Signed-off-by: Chris Ball <chris@printf.net>
> ---
> Hi,
>
> sdhci-s3c is currently failing to build due to the removal of
> card_tasklet. I think this trivial patch might do the right
> thing -- please could someone test that card detection still
> works and ACK if so? Thanks!
>
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 781b8a9..53a32e2 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
> clk_disable_unprepare(sc->clk_io);
> #endif
> }
> - tasklet_schedule(&host->card_tasklet);
> spin_unlock_irqrestore(&host->lock, flags);
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists
2014-06-04 22:56 ` Jaehoon Chung
@ 2014-06-05 2:13 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2014-06-05 2:13 UTC (permalink / raw)
To: Jaehoon Chung; +Cc: linux-mmc, Ulf Hansson, Kyungmin Park, Tomasz Figa
Hi,
On Wed, Jun 04 2014, Jaehoon Chung wrote:
> Didn't you want to merge the below patch?
>
> https://patchwork.kernel.org/patch/4239541/
>
> I have tested with exynos series, and working fine.
Oops, of course -- thanks! Pushed to mmc-next for 3.16.
- Chris.
--
Chris Ball <http://printf.net/>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-05 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-04 19:08 [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists Chris Ball
2014-06-04 22:56 ` Jaehoon Chung
2014-06-05 2:13 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox