From: Chris Ball <chris@printf.net>
To: Grant Grundler <grundler@chromium.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Puthikorn Voravootivat <puthik@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v2] mmc-utils: add eMMC 5.0 FFU support
Date: Sun, 02 Feb 2014 17:52:13 +0000 [thread overview]
Message-ID: <86wqhdxv02.fsf@void.printf.net> (raw)
In-Reply-To: <1390506264-17107-1-git-send-email-grundler@chromium.org> (Grant Grundler's message of "Thu, 23 Jan 2014 11:44:24 -0800")
Hi Grant,
Still waiting on the remaining warning/error, and also noticed a
trivial typo:
On Thu, Jan 23 2014, Grant Grundler wrote:
> + /* 2) Host send CMD6 to set MODE_CONFIG[30] = 0x01 */
> + memset(&idata, 0, sizeof(idata));
> + idata.opcode = MMC_SWITCH;
> + idata.arg = (MMC_SWITCH_MODE_WRITE_BYTE << 24) |
> + (30 << 16) | /* index */
> + (1 << 8) | /* value */
> + EXT_CSD_CMD_SET_NORMAL;
> + idata.flags = MMC_RSP_R1B | MMC_CMD_AC;;
> + ret = ioctl(fd, MMC_IOC_CMD, &idata);
> + if (ret) {
> + retcode = ret;
> + printf("ioctl: MMC_SWITCH (eMMC 5.0 FW Update) %m\n");
> + goto abort_update;
> + }
> +
> + /* 2) send CMD25 0x0000FFFF */
I think that first 2) should be a 1). Thanks,
- Chris.
--
Chris Ball <chris@printf.net> <http://printf.net/>
next prev parent reply other threads:[~2014-02-02 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:44 [PATCH v2] mmc-utils: add eMMC 5.0 FFU support Grant Grundler
2014-01-29 1:34 ` Chris Ball
2014-02-02 17:52 ` Chris Ball [this message]
2014-02-03 17:21 ` Grant Grundler
2014-02-06 11:57 ` Alex Lemberg
2014-02-06 18:41 ` Grant Grundler
2014-02-09 9:06 ` Alex Lemberg
2014-02-21 21:27 ` Grant Grundler
2014-02-21 21:31 ` Grant Grundler
2014-02-26 23:07 ` Alex Lemberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wqhdxv02.fsf@void.printf.net \
--to=chris@printf.net \
--cc=grundler@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox