From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>, linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: pxamci: prepare and unprepare the clocks
Date: Mon, 01 Sep 2014 14:20:58 +0200 [thread overview]
Message-ID: <871trv5y6t.fsf@free.fr> (raw)
In-Reply-To: <CAPDyKFr2SXz2yco5jzbkmrRZvCNQNbA7OjjX=WAtmcBJ1vYynw@mail.gmail.com> (Ulf Hansson's message of "Mon, 1 Sep 2014 12:31:04 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
>
> I would suggest you to re-place the existing clk_enable() with
> clk_prepare_enable() and clk_disable with clk_disable_unprepare()
> instead of the approach taken in this patch.
I don't think it works in this driver.
Look at pxamci_set_ios(), and all the handling of host->clkrt (CLKRT_OFF,
...). This driver enables the clock only when transfers are required, not all
the time. Therefore I'd rather let it be that way.
Cheers.
--
Robert
next prev parent reply other threads:[~2014-09-01 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 19:56 [PATCH] mmc: pxamci: prepare and unprepare the clocks Robert Jarzmik
2014-09-01 9:09 ` Robert Jarzmik
2014-09-01 10:31 ` Ulf Hansson
2014-09-01 12:20 ` Robert Jarzmik [this message]
2014-09-01 12:49 ` Ulf Hansson
2014-09-01 13:28 ` Robert Jarzmik
2014-09-02 7:53 ` Ulf Hansson
2014-09-02 9:02 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871trv5y6t.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox