From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2] MMC: tmio: fix unbalanced power-on calls with clock-gating enabled
Date: Thu, 06 Jun 2013 07:43:28 -0400 [thread overview]
Message-ID: <871u8f8nxb.fsf@octavius.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1304230916270.1422@axis700.grange> (Guennadi Liakhovetski's message of "Tue, 23 Apr 2013 09:29:44 +0200 (CEST)")
Hi,
On Tue, Apr 23 2013, Guennadi Liakhovetski wrote:
> With MMC clock gating enabled the MMC core currently calls MMC host driver's
> .set_ios() method with .power_mode == MMC_POWER_ON and the clock value set
> either to 0 or to the target rate. The tmio MMC driver then wrongly
> translates the latter calls to card slot power-on requests, even when the
> slot already was on. This patch fixes the driver to avoid needlessly
> incrementing power-supplying regulator's use count.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
This doesn't apply to mmc-next -- please could you rebase/resend?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2013-06-06 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 7:29 [PATCH v2] MMC: tmio: fix unbalanced power-on calls with clock-gating enabled Guennadi Liakhovetski
2013-04-24 22:16 ` Laurent Pinchart
2013-06-06 7:34 ` Guennadi Liakhovetski
2013-06-06 11:43 ` Chris Ball [this message]
2013-06-06 14:35 ` [PATCH v3 1/2] mmc: " Guennadi Liakhovetski
2013-06-06 14:35 ` [PATCH v3 2/2] mmc: tmio: reset the controller after power-up Guennadi Liakhovetski
2013-06-06 15:48 ` Chris Ball
2013-06-06 15:48 ` [PATCH v3 1/2] mmc: tmio: fix unbalanced power-on calls with clock-gating enabled Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u8f8nxb.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox