public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Johan Rudholm <jrudholm@gmail.com>,
	Seungwon Jeon <tgih.jun@samsung.com>,
	linux-mmc@vger.kernel.org,
	Konstantin Dorfman <kdorfman@codeaurora.org>
Subject: Re: [PATCH] mmc: block: fix the host's claim-release in special request
Date: Fri, 22 Mar 2013 13:05:16 -0400	[thread overview]
Message-ID: <871ub7mkkz.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAPDyKFo2dkEp4n3gcwKbJ0NB+G_zAiKwPLxsBaZXJFvqQ1JFiQ@mail.gmail.com> (Ulf Hansson's message of "Thu, 14 Mar 2013 15:49:27 +0100")

Hi,

On Thu, Mar 14 2013, Ulf Hansson wrote:
>> 2013/3/14 Seungwon Jeon <tgih.jun@samsung.com>:
>>> For normal request mmc_blk_issue_rq is called twice with asynchronous
>>> transfer(cur and prev). Host's claim and release can be done in each
>>> mmc_blk_issue_rq. However, Special request is currently excluded in
>>> asynchronous transfer. After special request is finished, if there is
>>> no new request, mmc_release_host won't be called in mmc_blk_issue_rq.
>>> The problem is founded during mmc_suspend.
>>>
>>> [<c0541124>] (__schedule+0x0/0x78c) from [<c05419e8>] (schedule+0x38/0x78)
>>> [<c05419b0>] (schedule+0x0/0x78) from [<c03a843c>]
>>> (__mmc_claim_host+0xac/0x1b4)
>>> [<c03a8390>] (__mmc_claim_host+0x0/0x1b4) from [<c03ac98c>]
>>> (mmc_suspend+0x28/0x9c)
>>> [<c03ac964>] (mmc_suspend+0x0/0x9c) from [<c03aad24>]
>>> (mmc_suspend_host+0xb4/0x194)
>>> ...
>>>
>>> Reported-by: Johan Rudholm <jrudholm@gmail.com>
>>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>>
>> Thank you for the quick response and fix! This fixes the problem. So
>> please include my
>>
>> Tested-by: Johan Rudholm <johan.rudholm@stericsson.com>
>
> Chris, could you send this for the 3.9 rc, since it is a bugfix?

Thanks, pushed to mmc-next for 3.9-rc.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2013-03-22 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  6:17 [PATCH] mmc: block: fix the host's claim-release in special request Seungwon Jeon
2013-03-14 11:56 ` Johan Rudholm
2013-03-14 14:49   ` Ulf Hansson
2013-03-22 17:05     ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ub7mkkz.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=jrudholm@gmail.com \
    --cc=kdorfman@codeaurora.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox