From: Chris Ball <cjb@laptop.org>
To: Wilson & Cassie <griscruf@comcast.net>
Cc: linux-mmc@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
wilson.callan@savantsystems.com
Subject: Re: [PATCH] esdhc: fix DMA_MASK to not break mx25 DMA access
Date: Thu, 19 Jul 2012 02:51:21 -0400 [thread overview]
Message-ID: <871uk89rbq.fsf@octavius.laptop.org> (raw)
In-Reply-To: <8D8658B1-9B29-4677-8CA8-EBEE0C42D3E6@comcast.net> (Wilson & Cassie's message of "Tue, 17 Jul 2012 12:32:05 -0400")
Hi,
On Tue, Jul 17 2012, Wilson & Cassie wrote:
> Patch to not set reserved bits in i.MX25 PROCTL register. DMA stops working if those bits get set.
>
> Signed-off-by: Wilson Callan <wilson.callan at savantsystems.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> --- linux-3.4.4/drivers/mmc/host/sdhci-esdhc-imx.c.orig 2012-07-04 13:58:16.239979741 -0400
> +++ linux-3.4.4/drivers/mmc/host/sdhci-esdhc-imx.c 2012-07-04 14:34:38.939949292 -0400
> @@ -310,8 +310,10 @@ static void esdhc_writeb_le(struct sdhci
> SDHCI_CTRL_D3CD);
> /* ensure the endianess */
> new_val |= ESDHC_HOST_CONTROL_LE;
> - /* DMA mode bits are shifted */
> - new_val |= (val & SDHCI_CTRL_DMA_MASK) << 5;
> + if (!is_imx25_esdhc(imx_data)) { // bits 8&9 are reserved on mx25
> + /* DMA mode bits are shifted */
> + new_val |= (val & SDHCI_CTRL_DMA_MASK) << 5;
> + }
>
> esdhc_clrset_le(host, 0xffff, new_val, reg);
> return;
Thanks, pushed to mmc-next for 3.6.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-07-19 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AF702D0F-8919-4E98-BD6C-DF05E0EE4DDE@savantav.com>
[not found] ` <3DC84FDD-7D96-46D6-A9F2-C3F8A47E9051@comcast.net>
[not found] ` <20120716214711.GX30009@pengutronix.de>
2012-07-17 16:32 ` [PATCH] esdhc: fix DMA_MASK to not break mx25 DMA access Wilson & Cassie
2012-07-19 6:51 ` Chris Ball [this message]
2012-07-22 20:47 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uk89rbq.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=griscruf@comcast.net \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=wilson.callan@savantsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox