* [PATCH 4/15] vub300: fix module parameter.
@ 2011-12-15 3:04 Rusty Russell
2011-12-16 19:02 ` Tony Olech
0 siblings, 1 reply; 5+ messages in thread
From: Rusty Russell @ 2011-12-15 3:04 UTC (permalink / raw)
To: lkml - Kernel Mailing List
Cc: Pawel Moll, Tony Olech, Chris Ball, linux-mmc, linux-usb
You didn't mean this to be a bool.
Cc: Tony Olech <tony.olech@elandigitalsystems.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/mmc/host/vub300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
static int firmware_rom_wait_states = 0x1C;
#endif
-module_param(firmware_rom_wait_states, bool, 0644);
+module_param(firmware_rom_wait_states, int, 0644);
MODULE_PARM_DESC(firmware_rom_wait_states,
"ROM wait states byte=RRRIIEEE (Reserved Internal External)");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 4/15] vub300: fix module parameter.
2011-12-15 3:04 [PATCH 4/15] vub300: fix module parameter Rusty Russell
@ 2011-12-16 19:02 ` Tony Olech
2011-12-19 2:20 ` Rusty Russell
2011-12-19 13:08 ` Tony Olech
0 siblings, 2 replies; 5+ messages in thread
From: Tony Olech @ 2011-12-16 19:02 UTC (permalink / raw)
To: Rusty Russell
Cc: tony, lkml - Kernel Mailing List, Pawel Moll, Chris Ball,
linux-mmc, linux-usb
You are right.
I don't know how that slipped through
Tony Olech
On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote:
> You didn't mean this to be a bool.
>
> Cc: Tony Olech <tony.olech@elandigitalsystems.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/mmc/host/vub300.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
> static int firmware_rom_wait_states = 0x1C;
> #endif
>
> -module_param(firmware_rom_wait_states, bool, 0644);
> +module_param(firmware_rom_wait_states, int, 0644);
> MODULE_PARM_DESC(firmware_rom_wait_states,
> "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 4/15] vub300: fix module parameter.
2011-12-16 19:02 ` Tony Olech
@ 2011-12-19 2:20 ` Rusty Russell
2011-12-20 0:03 ` Chris Ball
2011-12-19 13:08 ` Tony Olech
1 sibling, 1 reply; 5+ messages in thread
From: Rusty Russell @ 2011-12-19 2:20 UTC (permalink / raw)
To: Tony Olech
Cc: tony, lkml - Kernel Mailing List, Pawel Moll, Chris Ball,
linux-mmc, linux-usb
On Fri, 16 Dec 2011 19:02:02 +0000, Tony Olech <tony.olech@elandigitalsystems.com> wrote:
> You are right.
> I don't know how that slipped through
> Tony Olech
I'm assuming that means you're taking this? Otherwise, please give me
an acked-by.
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 4/15] vub300: fix module parameter.
2011-12-19 2:20 ` Rusty Russell
@ 2011-12-20 0:03 ` Chris Ball
0 siblings, 0 replies; 5+ messages in thread
From: Chris Ball @ 2011-12-20 0:03 UTC (permalink / raw)
To: Rusty Russell
Cc: Tony Olech, tony, lkml - Kernel Mailing List, Pawel Moll,
linux-mmc, linux-usb
Hi Rusty,
On Sun, Dec 18 2011, Rusty Russell wrote:
> On Fri, 16 Dec 2011 19:02:02 +0000, Tony Olech
> <tony.olech@elandigitalsystems.com> wrote:
>> You are right.
>> I don't know how that slipped through
>> Tony Olech
>
> I'm assuming that means you're taking this? Otherwise, please give me
> an acked-by.
Thanks, I'll send this for 3.2 with Tony's ACK.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 4/15] vub300: fix module parameter.
2011-12-16 19:02 ` Tony Olech
2011-12-19 2:20 ` Rusty Russell
@ 2011-12-19 13:08 ` Tony Olech
1 sibling, 0 replies; 5+ messages in thread
From: Tony Olech @ 2011-12-19 13:08 UTC (permalink / raw)
To: Rusty Russell
Cc: lkml - Kernel Mailing List, Pawel Moll, Chris Ball, linux-mmc,
linux-usb
On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote:
> You didn't mean this to be a bool.
>
> Cc: Tony Olech <tony.olech@elandigitalsystems.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/mmc/host/vub300.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
> static int firmware_rom_wait_states = 0x1C;
> #endif
>
> -module_param(firmware_rom_wait_states, bool, 0644);
> +module_param(firmware_rom_wait_states, int, 0644);
> MODULE_PARM_DESC(firmware_rom_wait_states,
> "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
>
> --
You are right.
I don't know how that slipped through
Acked-by: Tony Olech <tony.olech@elandigitalsystems.com>
Acked-by: Tony Olech <tony@olech.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-20 0:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-15 3:04 [PATCH 4/15] vub300: fix module parameter Rusty Russell
2011-12-16 19:02 ` Tony Olech
2011-12-19 2:20 ` Rusty Russell
2011-12-20 0:03 ` Chris Ball
2011-12-19 13:08 ` Tony Olech
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).