public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Sergey Yanovich <ynvich@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Namjae Jeon <linkinjeon@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] wait while adding MMC host to ensure root mounts
Date: Sat, 13 Apr 2013 08:52:21 -0400	[thread overview]
Message-ID: <8738uubnju.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1365850153.9806.59.camel@host5.omatika.ru> (Sergey Yanovich's message of "Sat, 13 Apr 2013 14:49:13 +0400")

Hi,

On Sat, Apr 13 2013, Sergey Yanovich wrote:
> On Wed, 2013-03-27 at 07:57 -0400, Chris Ball wrote:
>> If the delay's significant, I agree with you and will revert this patch.
>
> The patch was reverted. The problem is back. Filed bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=56561
>
> A possible solution is to make card a separate device (now only the host
> is a device). In this case, the probing could be done asynchronously
> without breaking the assumption in prepare_namespace().
>
> Chris, could you comment?

The same problem (of requiring rootwait) exists when trying to boot
from a SCSI/USB device, so I don't think there's any MMC-specific
problem here.  Most people who aren't using an initrd have to supply
rootwait.

I liked the idea behind your patch, but the performance regression
isn't acceptable.  If we can't find a way to conditionalize the call
to mmc_flush_scheduled_work() on being in a situation where we're
definitely about to panic, I think the only option would be to try
to come up with a solution at the layers above MMC.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2013-04-13 12:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14  1:06 [PATCH] wait while adding MMC host to ensure root mounts Sergey Yanovich
2013-03-14  1:23 ` [PATCH v2] " Sergey Yanovich
2013-03-14  4:08   ` Namjae Jeon
2013-03-14 11:57     ` Sergey Yanovich
2013-03-15  2:51     ` Jaehoon Chung
2013-03-22 17:03   ` Chris Ball
2013-03-27 11:13     ` Ulf Hansson
2013-03-27 11:57       ` Chris Ball
2013-04-02 13:36         ` Adrian Hunter
2013-04-02 14:24           ` Sergey Yanovich
2013-04-04  6:35             ` Adrian Hunter
2013-04-04 10:59               ` Sergey Yanovich
2013-04-04 11:35                 ` Adrian Hunter
2013-04-04 12:32                   ` Sergey Yanovich
2013-04-13 10:49         ` Sergey Yanovich
2013-04-13 12:52           ` Chris Ball [this message]
     [not found]           ` <CAPDyKFrF8pmo7mfa_1Vi2n=JBFd1h+VULQ1hJB75=DmNx0erdw@mail.gmail.com>
2013-04-13 12:52             ` Sergey Yanovich
2013-03-27 12:28       ` Сергей Янович
2013-04-02 10:13         ` Ulf Hansson
2013-04-02 10:35           ` Sergey Yanovich
2013-04-02 17:45             ` Ulf Hansson
2013-04-02 18:56               ` Sergey Yanovich
2013-03-14  2:47 ` [PATCH] " Greg Kroah-Hartman
2013-03-14 10:28   ` Sergey Yanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738uubnju.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jh80.chung@samsung.com \
    --cc=linkinjeon@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=ynvich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox