From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, Will Newton <will.newton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] mmc: dw_mmc: convert the variable type of irq
Date: Tue, 23 Oct 2012 17:03:53 -0400 [thread overview]
Message-ID: <873914j3ye.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAFbHwiSZ9Wi+cTxvMWLm2U84jOVstrZNhwjDgXJZzW3ZSCB8gg@mail.gmail.com> (Will Newton's message of "Fri, 28 Sep 2012 11:00:24 +0100")
Hi,
On Fri, Sep 28 2012, Will Newton wrote:
> On Fri, Sep 28, 2012 at 6:21 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> Even though platform_get_irq returns error, 'host->irq'
>> always has an unsigned value. Less-than-zero comparison
>> of an unsigned value is never true. Type of 'unsigned int'
>> will be changed for 'int'.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> ---
>> include/linux/mmc/dw_mmc.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-10-23 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 5:21 [PATCH] mmc: dw_mmc: convert the variable type of irq Seungwon Jeon
2012-09-28 10:00 ` Will Newton
2012-10-23 21:03 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873914j3ye.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=will.newton@gmail.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox