From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: dw_mmc: move host->data_offset init earlier Date: Fri, 22 Mar 2013 12:45:01 -0400 Message-ID: <874ng3o036.fsf@octavius.laptop.org> References: <1363085034-9270-1-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:57282 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933488Ab3CVQpG (ORCPT ); Fri, 22 Mar 2013 12:45:06 -0400 In-Reply-To: <1363085034-9270-1-git-send-email-james.hogan@imgtec.com> (James Hogan's message of "Tue, 12 Mar 2013 10:43:54 +0000") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: James Hogan Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Seungwon Jeon , Jaehoon Chung Hi, On Tue, Mar 12 2013, James Hogan wrote: > host->data_offset is initialised at the end of the probe function > depending on the VERID register, and is used for PIO operations. Move > this initialisation earlier, before IRQs or slots are initialised, to be > sure that PIO won't occur prior to host->data_offset being initialised. > > Signed-off-by: James Hogan > Cc: Seungwon Jeon > Cc: Jaehoon Chung > Cc: Chris Ball Thanks, pushed to mmc-next for 3.10. - Chris. -- Chris Ball One Laptop Per Child