From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v2 02/11] mmc: deprecate redundant cd-inverted and wp-inverted DT properties Date: Mon, 28 Jan 2013 17:23:32 -0500 Message-ID: <874ni16j6j.fsf@laptop.org> References: <1358955158-1510-1-git-send-email-g.liakhovetski@gmx.de> <1358955158-1510-3-git-send-email-g.liakhovetski@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1358955158-1510-3-git-send-email-g.liakhovetski@gmx.de> (Guennadi Liakhovetski's message of "Wed, 23 Jan 2013 16:32:29 +0100") Sender: linux-sh-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm List-Id: linux-mmc@vger.kernel.org Hi Guennadi, On Wed, Jan 23 2013, Guennadi Liakhovetski wrote: > +cd-inverted and wp-inverted properties are deprecated ans shouldn't be used, > +instead pleaseuse the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. Note, > +that the default (as defined by the SDHCI standard) CD and WP polarity is > +active-low, so, OF_GPIO_ACTIVE_LOW should normally be set, and only be left > +clear, if the polarity is inverted. Please use this text for your next version, fixing typos and a newline: cd-inverted and wp-inverted properties are deprecated and shouldn't be used, instead please use the OF_GPIO_ACTIVE_LOW flag in respective GPIO bindings. Note that the default (as defined by the SDHCI standard) CD and WP polarity is active-low, so OF_GPIO_ACTIVE_LOW should normally be set, and only be left clear if the polarity is inverted. Thanks, - Chris. -- Chris Ball One Laptop Per Child