* [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.
@ 2010-01-28 1:50 Thomas Abraham
2010-01-28 4:13 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Abraham @ 2010-01-28 1:50 UTC (permalink / raw)
To: linux-mmc; +Cc: ben-linux, kgene.kim, Thomas Abraham
This patch enables ADMA feature in S3C SDHCI controller driver. This patch
depends on the following patch.
[PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
---
drivers/mmc/host/sdhci-s3c.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 7400ba0..03f7e3b 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -341,12 +341,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
host->irq = irq;
/* Setup quirks for the controller */
-
- /* Currently with ADMA enabled we are getting some length
- * interrupts that are not being dealt with, do disable
- * ADMA until this is sorted out. */
- host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
- host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
+ host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
#ifndef CONFIG_MMC_SDHCI_S3C_DMA
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.
2010-01-28 1:50 [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller Thomas Abraham
@ 2010-01-28 4:13 ` Ben Dooks
2010-01-28 12:37 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2010-01-28 4:13 UTC (permalink / raw)
To: Thomas Abraham; +Cc: linux-mmc, ben-linux, kgene.kim
On Thu, Jan 28, 2010 at 10:50:38AM +0900, Thomas Abraham wrote:
> This patch enables ADMA feature in S3C SDHCI controller driver. This patch
> depends on the following patch.
>
> [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.
>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 7400ba0..03f7e3b 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -341,12 +341,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> host->irq = irq;
>
> /* Setup quirks for the controller */
> -
> - /* Currently with ADMA enabled we are getting some length
> - * interrupts that are not being dealt with, do disable
> - * ADMA until this is sorted out. */
> - host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
> - host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
> + host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
>
> #ifndef CONFIG_MMC_SDHCI_S3C_DMA
>
> --
> 1.5.3.4
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.
2010-01-28 4:13 ` Ben Dooks
@ 2010-01-28 12:37 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2010-01-28 12:37 UTC (permalink / raw)
To: Ben Dooks; +Cc: Thomas Abraham, linux-mmc, kgene.kim
>>>>> "Ben" == Ben Dooks <ben-linux@fluff.org> writes:
Ben> On Thu, Jan 28, 2010 at 10:50:38AM +0900, Thomas Abraham wrote:
>> This patch enables ADMA feature in S3C SDHCI controller driver. This patch
>> depends on the following patch.
>>
>> [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.
>>
>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
Ben> Acked-by: Ben Dooks <ben-linux@fluff.org>
If this solves the DMA issues, shouldn't we get rid of the
CONFIG_MMC_SDHCI_S3C_DMA kconfig and just always use DMA?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-28 12:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-28 1:50 [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller Thomas Abraham
2010-01-28 4:13 ` Ben Dooks
2010-01-28 12:37 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox