From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v3 1/2] mmc: tmio: fix unbalanced power-on calls with clock-gating enabled Date: Thu, 06 Jun 2013 11:48:38 -0400 Message-ID: <8761xr6y09.fsf@octavius.laptop.org> References: <871u8f8nxb.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Guennadi Liakhovetski's message of "Thu, 6 Jun 2013 16:35:44 +0200 (CEST)") Sender: linux-sh-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org List-Id: linux-mmc@vger.kernel.org Hi, On Thu, Jun 06 2013, Guennadi Liakhovetski wrote: > With MMC clock gating enabled the MMC core currently calls MMC host driver's > .set_ios() method with .power_mode == MMC_POWER_ON and the clock value set > either to 0 or to the target rate. The tmio MMC driver then wrongly > translates the latter calls to card slot power-on requests, even when the > slot already was on. This patch fixes the driver to avoid needlessly > incrementing power-supplying regulator's use count. > > Signed-off-by: Guennadi Liakhovetski > Tested-by: Laurent Pinchart > --- > > v3: rebased on top of current mmc-next / 3.10-rc Thanks, pushed to mmc-next for 3.10. - Chris. -- Chris Ball One Laptop Per Child