From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>
Subject: Re: My outstanding MMC / SDHI/TMIO / MMCIF patches for 3.6
Date: Sat, 30 Jun 2012 08:52:14 -0400 [thread overview]
Message-ID: <8762a99d35.fsf@octavius.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1206301243320.19932@axis700.grange> (Guennadi Liakhovetski's message of "Sat, 30 Jun 2012 12:45:55 +0200 (CEST)")
Hi,
On Sat, Jun 30 2012, Guennadi Liakhovetski wrote:
>> Could we get a file in Documentation/devicetree/bindings/mmc/ for the
>> new sh_mmcif DT bindings you've added, please? It can come as a new
>> patch on top of these. I know it'll be very short right now; you can
>> at least show an example of a DT node that works.
>
> I added OF support to both sh_mmcif and sh_mobile_sdhi (tmio_mmc), but in
> both cases it's just at the most primitive level. This means, those
> drivers will only use reg and interrupts DT properties, nothing else so
> far. More shall be added in the future.
Right.
> Does this level of support also have to be documented?
Well, I think the idea is that someone should know how to hook up their
DT to the driver without hunting through the source code; right now they
at least have to read the source to find out that the required
compatible nodes are "renesas,sh-mmcif" and "renesas,shmobile-sdhi".
So the point of adding minimal documentation now would be to show how to
hook it up, and have some placeholder documentation that can be added to
once the driver supports more of the core MMC DT bindings (bus-width,
non-removable, ..). Seems like it couldn't hurt to add it?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-06-30 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 8:36 My outstanding MMC / SDHI/TMIO / MMCIF patches for 3.6 Guennadi Liakhovetski
2012-06-28 14:29 ` Chris Ball
2012-06-29 15:03 ` Guennadi Liakhovetski
2012-06-29 16:26 ` Chris Ball
2012-06-29 18:44 ` Guennadi Liakhovetski
2012-06-29 23:25 ` Chris Ball
2012-06-30 10:45 ` Guennadi Liakhovetski
2012-06-30 12:52 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762a99d35.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox