From: Chris Ball <cjb@laptop.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>, Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: omap: Fix broken reg_shift initialization
Date: Wed, 06 Jun 2012 09:48:46 -0400 [thread overview]
Message-ID: <8762b44kld.fsf@octavius.laptop.org> (raw)
In-Reply-To: <20120530071300.GH12766@atomide.com> (Tony Lindgren's message of "Wed, 30 May 2012 00:13:01 -0700")
Hi,
On Wed, May 30 2012, Tony Lindgren wrote:
> Commit fa550189 (mmc: core: Prevent eMMC VCC supply to be cut from late init)
> slightly affected timings for how things are done for the omap MMC driver
> causing the MMC cards not getting detected any longer.
>
> Turns out this was caused by buggy reg_shift initialization in the omap
> MMC driver that was happening after mmc_add_host() was being called.
>
> Fix this by initializing reg_shift before mmc_add_host() is called.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> ---
>
> Heh found it! Chris, maybe Cc stable on this one?
Thanks, pushed to mmc-next for 3.5 with a stable@ tag added.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-06-06 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 13:21 Regression for non-eMMC cards with commit fa550189? Tony Lindgren
2012-05-29 6:52 ` Ulf Hansson
2012-05-29 7:40 ` Felipe Balbi
2012-05-29 12:47 ` Tony Lindgren
2012-05-29 12:50 ` Felipe Balbi
2012-05-29 13:03 ` Tony Lindgren
2012-05-30 7:13 ` [PATCH] mmc: omap: Fix broken reg_shift initialization Tony Lindgren
2012-06-06 13:48 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762b44kld.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).