From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: omap: Fix broken reg_shift initialization Date: Wed, 06 Jun 2012 09:48:46 -0400 Message-ID: <8762b44kld.fsf@octavius.laptop.org> References: <20120528132147.GC12766@atomide.com> <20120529074047.GE16340@arwen.pp.htv.fi> <20120529124732.GD12766@atomide.com> <20120529125024.GM9577@arwen.pp.htv.fi> <20120529130312.GE12766@atomide.com> <20120530071300.GH12766@atomide.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20120530071300.GH12766@atomide.com> (Tony Lindgren's message of "Wed, 30 May 2012 00:13:01 -0700") Sender: linux-omap-owner@vger.kernel.org To: Tony Lindgren Cc: Felipe Balbi , Ulf Hansson , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org Hi, On Wed, May 30 2012, Tony Lindgren wrote: > Commit fa550189 (mmc: core: Prevent eMMC VCC supply to be cut from late init) > slightly affected timings for how things are done for the omap MMC driver > causing the MMC cards not getting detected any longer. > > Turns out this was caused by buggy reg_shift initialization in the omap > MMC driver that was happening after mmc_add_host() was being called. > > Fix this by initializing reg_shift before mmc_add_host() is called. > > Signed-off-by: Tony Lindgren > > --- > > Heh found it! Chris, maybe Cc stable on this one? Thanks, pushed to mmc-next for 3.5 with a stable@ tag added. - Chris. -- Chris Ball One Laptop Per Child